703898 - Remove superfluous |ifeq (,$(filter WINNT OS2,$(OS_ARCH)))| from build/unix/Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

build/Makefile.in does: (http://hg.mozilla.org/mozilla-central/file/46c2bd7dbdd4/build/Makefile.in#l48)
{
ifeq (,$(filter WINNT OS2,$(OS_ARCH)))
DIRS		= unix
endif
}

Therefore the |ifeq (,$(filter WINNT OS2,$(OS_ARCH)))| in build/unix/Makefile.in isn't required:
http://hg.mozilla.org/mozilla-central/file/46c2bd7dbdd4/build/unix/Makefile.in#l55

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 575680 [details] [diff] [review]
Patch v1

Review of attachment 575680 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/Makefile.in
@@ +52,5 @@
>  endif
>  
>  ifdef ENABLE_TESTS
> +DIRS += test
> +endif

Can you just change this to use TEST_DIRS while you're here?

Comment 3

[Ed Morley [:emorley]]

Attachment: Patch v1.1

Sure; done :-)

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41b52e1c5394

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/41b52e1c5394