The default bug view has changed. See this FAQ.

Remove superfluous |ifeq (,$(filter WINNT OS2,$(OS_ARCH)))| from build/unix/Makefile.in

RESOLVED FIXED in mozilla11

Status

()

Core
Build Config
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

build/Makefile.in does: (http://hg.mozilla.org/mozilla-central/file/46c2bd7dbdd4/build/Makefile.in#l48)
{
ifeq (,$(filter WINNT OS2,$(OS_ARCH)))
DIRS		= unix
endif
}

Therefore the |ifeq (,$(filter WINNT OS2,$(OS_ARCH)))| in build/unix/Makefile.in isn't required:
http://hg.mozilla.org/mozilla-central/file/46c2bd7dbdd4/build/unix/Makefile.in#l55
Created attachment 575680 [details] [diff] [review]
Patch v1
Attachment #575680 - Flags: review?(ted.mielczarek)
Comment on attachment 575680 [details] [diff] [review]
Patch v1

Review of attachment 575680 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/Makefile.in
@@ +52,5 @@
>  endif
>  
>  ifdef ENABLE_TESTS
> +DIRS += test
> +endif

Can you just change this to use TEST_DIRS while you're here?
Attachment #575680 - Flags: review?(ted.mielczarek) → review+
Created attachment 575836 [details] [diff] [review]
Patch v1.1

Sure; done :-)
Attachment #575680 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/41b52e1c5394
Flags: in-testsuite-
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/41b52e1c5394
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.