Last Comment Bug 703898 - Remove superfluous |ifeq (,$(filter WINNT OS2,$(OS_ARCH)))| from build/unix/Makefile.in
: Remove superfluous |ifeq (,$(filter WINNT OS2,$(OS_ARCH)))| from build/unix/M...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla11
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-19 09:50 PST by Ed Morley [:emorley]
Modified: 2011-12-01 04:40 PST (History)
3 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (694 bytes, patch)
2011-11-19 09:54 PST, Ed Morley [:emorley]
ted: review+
Details | Diff | Splinter Review
Patch v1.1 (710 bytes, patch)
2011-11-21 05:31 PST, Ed Morley [:emorley]
no flags Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2011-11-19 09:50:41 PST
build/Makefile.in does: (http://hg.mozilla.org/mozilla-central/file/46c2bd7dbdd4/build/Makefile.in#l48)
{
ifeq (,$(filter WINNT OS2,$(OS_ARCH)))
DIRS		= unix
endif
}

Therefore the |ifeq (,$(filter WINNT OS2,$(OS_ARCH)))| in build/unix/Makefile.in isn't required:
http://hg.mozilla.org/mozilla-central/file/46c2bd7dbdd4/build/unix/Makefile.in#l55
Comment 1 Ed Morley [:emorley] 2011-11-19 09:54:24 PST
Created attachment 575680 [details] [diff] [review]
Patch v1
Comment 2 Ted Mielczarek [:ted.mielczarek] 2011-11-21 04:52:48 PST
Comment on attachment 575680 [details] [diff] [review]
Patch v1

Review of attachment 575680 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/Makefile.in
@@ +52,5 @@
>  endif
>  
>  ifdef ENABLE_TESTS
> +DIRS += test
> +endif

Can you just change this to use TEST_DIRS while you're here?
Comment 3 Ed Morley [:emorley] 2011-11-21 05:31:34 PST
Created attachment 575836 [details] [diff] [review]
Patch v1.1

Sure; done :-)
Comment 5 Marco Bonardo [::mak] (Away 6-20 Aug) 2011-12-01 04:40:33 PST
https://hg.mozilla.org/mozilla-central/rev/41b52e1c5394

Note You need to log in before you can comment on or make changes to this bug.