Last Comment Bug 703990 - incorrect/misleading messages in test_tooltip.xul
: incorrect/misleading messages in test_tooltip.xul
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XUL (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Jonathan Kew (:jfkthame)
:
: Neil Deakin
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-20 08:57 PST by Jonathan Kew (:jfkthame)
Modified: 2011-11-21 09:07 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch, fix the incorrect messages (3.12 KB, patch)
2011-11-20 08:57 PST, Jonathan Kew (:jfkthame)
enndeakin: review+
Details | Diff | Splinter Review

Description Jonathan Kew (:jfkthame) 2011-11-20 08:57:31 PST
Created attachment 575751 [details] [diff] [review]
patch, fix the incorrect messages

In toolkit/content/tests/chrome/test_tooltip.xul, there are three fragments of the form

    is(Math.round(rect.left),
       Math.round(buttonrect.left + parseFloat(popupstyle.marginLeft) + 6),
       testname + " top position of tooltip");

which report that they're testing the "top position", when they really mean to say "left position". ("Top position" is tested immediately afterwards in each case.)
Comment 2 Matt Brubeck (:mbrubeck) 2011-11-21 09:07:35 PST
https://hg.mozilla.org/mozilla-central/rev/ce874976149f

Note You need to log in before you can comment on or make changes to this bug.