704032 - (firefox-trunk:6534): GLib-GObject-CRITICAL **: g_object_unref: assertion `object->ref_count > 0' failed

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[aguado.leonardo]

User Agent: Mozilla/5.0 (Ubuntu; X11; Linux i686; rv:11.0a1) Gecko/20111116 Firefox/11.0a1
Build ID: 20111116073340

Steps to reproduce:

I was running firefox-trunk 11.0a1 with trickle (a bandwidth shape tool, maybe that's the problem).



Actual results:

Firefox crashed. No crash report. In console i got this:
(firefox-trunk:6534): GLib-GObject-CRITICAL **: g_object_unref: assertion `object->ref_count > 0' failed



Expected results:

Normal behaviour

Comment 1

[:aceman]

Is this an official firefox build from mozilla.org?

Comment 2

[aguado.leonardo]

I think it's not. The about menu says "Mozilla firefox for Ubuntu canonical". I got it from this repo: http://ppa.launchpad.net/ubuntu-mozilla-daily/ppa/ubuntu, so i think it's not the official build.

Comment 3

[:aceman]

That may be the reason you get no crash report. It would be useless for mozilla developers working on official build. Could you try the official one if it crashes in the same way?

Comment 4

[bugzilla]

  As of Saturday, 9Sep2017, I have the same problem with Firefox Nightly on Debian Jessie.  When started from a terminal window, it prints:

 (firefox:21457): GLib-GObject-CRITICAL **: g_object_ref: assertion 'object->ref_count > 0' failed

 (firefox:21457): GLib-GObject-CRITICAL **: g_object_unref: assertion 'object->ref_count > 0' failed

several times during a session.  I don't know what causes this but am guessing it's a gobject reference problem.  I find gobject reference problems difficult to debug but, by adding print statements, have been able to find a change which stops the printing.

  In the file widget/gtk/WidgetStyleCache.cpp , by adding:

    (void) g_object_ref(context)

in the CreateCSSNode function immediately after the GtkStyleContext *context = gtk_style_context_new() line & rebuilding Firefox nightly, the annoying statements disappear.

  If no one objects & if I can figure out how to submit my change to Mozilla, I will make the change & submit it.

Comment 5

[bugzilla]

Attachment: Workaround (not fix, I don't really understand the problem) for Bugzilla 704032

Review commit: https://reviewboard.mozilla.org/r/178116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178116/

Comment 6

[qiaopengcheng]

I also meet this problem on firefox-esr52 mips64-linux.

Printing message like:

(firefox:8605): GLib-GObject-CRITICAL **: g_object_ref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_unref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_ref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_unref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_ref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_unref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_ref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_unref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_ref: assertion 'object->ref_count > 0' failed

(firefox:8605): GLib-GObject-CRITICAL **: g_object_unref: assertion 'object->ref_count > 0' failed

------------------------------------------------------------------------------------------------------

(In reply to bugzilla from comment #4)
> 
>   In the file widget/gtk/WidgetStyleCache.cpp , by adding:
> 
>     (void) g_object_ref(context)
> 
> in the CreateCSSNode function immediately after the GtkStyleContext *context
> = gtk_style_context_new() line & rebuilding Firefox nightly, the annoying
> statements disappear.
> 


I have tried this method on mips64-linux and that eliminates the printing message.

Thank You!!!

Comment 7

[qiaopengcheng]

(In reply to bugzilla from comment #4)

>   In the file widget/gtk/WidgetStyleCache.cpp , by adding:
> 
>     (void) g_object_ref(context)
> 
> in the CreateCSSNode function immediately after the GtkStyleContext *context
> = gtk_style_context_new() line & rebuilding Firefox nightly, the annoying
> statements disappear.
> 
>   If no one objects & if I can figure out how to submit my change to
> Mozilla, I will make the change & submit it.


I think you can generate a patch through git or hg  during firefox source code directory.
And commit the patch with committing information.

Comment 8

[Philippe Lefèvre]

Also affected by this bug present in firefox Dev 59 to 61.0b5 (64 bits) and firefox ESR 52.8.0 (64 bits)