Closed
Bug 704034
Opened 13 years ago
Closed 13 years ago
loopstart, loopend, playcount attributes in AttributeName.java no longer exist in the spec
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: kinetik, Assigned: hsivonen)
References
Details
Attachments
(1 file)
|
80.68 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
The loopstart, loopend, and playcount attributes were removed when the media element's looping support was changed to a simple boolean attribute "loop".
AttributeName.java is also missing the new(er) loop attribute.
I didn't understand the process to modify and regenerate this code well enough to submit a patch, but I'm happy to do so if someone can walk me through it.
|
Assignee | |
Comment 1•13 years ago
|
||
Thanks. I can take care of the removal and regeneration.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #575841 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 3•13 years ago
|
||
There's no test, because these pre-interned tokens affect the number of allocations the parser does. Hence, the effect of this patch isn't really testable.
Flags: in-testsuite-
|
||
Comment 4•13 years ago
|
||
Comment on attachment 575841 [details] [diff] [review]
Add loop and remove the old ones
rs=me
Attachment #575841 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Target Milestone: --- → mozilla11
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•