The default bug view has changed. See this FAQ.

loopstart, loopend, playcount attributes in AttributeName.java no longer exist in the spec

RESOLVED FIXED in mozilla11

Status

()

Core
HTML: Parser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kinetik, Assigned: hsivonen)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The loopstart, loopend, and playcount attributes were removed when the media element's looping support was changed to a simple boolean attribute "loop".

AttributeName.java is also missing the new(er) loop attribute.

I didn't understand the process to modify and regenerate this code well enough to submit a patch, but I'm happy to do so if someone can walk me through it.
(Assignee)

Comment 1

5 years ago
Thanks. I can take care of the removal and regeneration.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Depends on: 704058
(Assignee)

Comment 2

5 years ago
Created attachment 575841 [details] [diff] [review]
Add loop and remove the old ones
Attachment #575841 - Flags: review?(bugs)
(Assignee)

Comment 3

5 years ago
There's no test, because these pre-interned tokens affect the number of allocations the parser does. Hence, the effect of this patch isn't really testable.
Flags: in-testsuite-

Comment 4

5 years ago
Comment on attachment 575841 [details] [diff] [review]
Add loop and remove the old ones

rs=me
Attachment #575841 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d2f327980ff
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/4d2f327980ff
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.