The default bug view has changed. See this FAQ.

remove 'countryCode' from nsIDOMGeoPositionAddress.idl

RESOLVED FIXED in mozilla11

Status

()

Core
Geolocation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Masataka Yakura, Assigned: emorley)

Tracking

({addon-compat, dev-doc-complete})

Trunk
mozilla11
addon-compat, dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/535.10 (KHTML, like Gecko) Chrome/17.0.945.0 Safari/535.10

Steps to reproduce:

Looked at http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/geolocation/nsIDOMGeoPositionAddress.idl


Actual results:

found nsIDOMGeoPositionAddress.idl defines a property called 'countryCode' which isn't defined in the Geolocation v2 specification.


Expected results:

Per the spec, 'country' property "is specified using the two-letter [ISO 3166-1] code." so it seems 'countryCode' is pretty redundant. Rather than keeping undefined property or consult Geolocation WG to have it specified, I suggest removing it from Gecko.
Created attachment 581609 [details] [diff] [review]
Patch v1

Doug, can you confirm this is wanted please? :-)

https://tbpl.mozilla.org/?tree=Try&rev=403b9f4b60d2
Assignee: nobody → bmo
Attachment #581609 - Flags: feedback?(doug.turner)

Updated

5 years ago
Attachment #581609 - Flags: feedback?(doug.turner) → feedback+
Attachment #581609 - Flags: review?(doug.turner)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Updated

5 years ago
Attachment #581609 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d0ffc477fe8
Flags: in-testsuite-
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/1d0ffc477fe8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: addon-compat, dev-doc-needed
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED

Comment 4

5 years ago
I noted the attribute's removal at https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIDOMGeoPositionAddress , not sure if anything else needs to be done here.
I added a mention to Firefox 11 for developers and verified this property isn't used in any examples.

That article does need to move to the DOM reference with appropriate reformatting, but that's a separate issue.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.