704056 - remove 'countryCode' from nsIDOMGeoPositionAddress.idl

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Masataka Yakura [:myakura]]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/535.10 (KHTML, like Gecko) Chrome/17.0.945.0 Safari/535.10

Steps to reproduce:

Looked at http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/geolocation/nsIDOMGeoPositionAddress.idl


Actual results:

found nsIDOMGeoPositionAddress.idl defines a property called 'countryCode' which isn't defined in the Geolocation v2 specification.


Expected results:

Per the spec, 'country' property "is specified using the two-letter [ISO 3166-1] code." so it seems 'countryCode' is pretty redundant. Rather than keeping undefined property or consult Geolocation WG to have it specified, I suggest removing it from Gecko.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Doug, can you confirm this is wanted please? :-)

https://tbpl.mozilla.org/?tree=Try&rev=403b9f4b60d2

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d0ffc477fe8

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1d0ffc477fe8

Comment 4

[Nickolay_Ponomarev]

I noted the attribute's removal at https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIDOMGeoPositionAddress , not sure if anything else needs to be done here.

Comment 5

[Eric Shepherd [:sheppy]]

I added a mention to Firefox 11 for developers and verified this property isn't used in any examples.

That article does need to move to the DOM reference with appropriate reformatting, but that's a separate issue.