704118 - Add missing tooltips on Webconsole toolbar

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Comment 1

[Sonny Piers [:sonny]]

The toolbarbutton builders use the tooltip attribute instead of the tooltiptext attribute.

Comment 2

[Sonny Piers [:sonny]]

Attachment: patch v1

Comment 3

[Sonny Piers [:sonny]]

I think it's a bad thing to have tooltips on certain items but not on all of them.
Users might expect to get a tooltip on all buttons.

Comment 4

[Mihai Sucan [:msucan]]

Comment on attachment 575946 [details] [diff] [review]
patch v1

Review of attachment 575946 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks like it needs a rebase (or bug dependencies are not set?). The patch didn't apply cleanly (a hunk in webconsole.properties was rejected). I manually applied it, but things are still broken.

Web Console fails to open:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/HUDService.jsm :: HUD_getStr :: line 3512"  data: no]

(this is because some string wasn't found)


Please rebase the patch. Otherwise the patch looks good! More comments below.

Thank you very much for your work!

::: browser/locales/en-US/chrome/browser/devtools/webconsole.properties
@@ +12,5 @@
>  categoryConsole=Console:
>  btnMutation=DOM Mutation
>  tipMutation=Toggle DOM Mutation event logging
>  btnPageNet=Net
> +tipPageNet=Log network requests

Log network requests and responses

@@ +17,2 @@
>  btnPageCSS=CSS
> +tipPageCSS=Log CSS parsing messages

Both strings need to be renamed.

@@ +171,5 @@
> +tipFilter=Filter trough logs
> +
> +webConsolePositionTooltip=Position the Web Console
> +webConsolePositionAboveTooltip=Position the Web Console to the above
> +webConsolePositionBelowTooltip=Position the Web Console to the below

Position the Web Console above the page
Position the Web Console below the page

Comment 5

[Joe Walker [:jwalker]]

We now have tooltips in the web console toolbar.