704123 - Inspect Element background shading in document too dark

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Bill Barry]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111118 Firefox/10.0a2
Build ID: 20111118042017

Steps to reproduce:

right click - inspect element


Actual results:

opened highlighter interface, noticed background shading is too dark


Expected results:

The background shading used for the document shading when a modal popup is opened (an alert message for example) is what should be used for the background shading in the highlighter.

Comment 1

[Dave Camp (:dcamp)]

(In reply to Bill Barry from comment #0)

> The background shading used for the document shading when a modal popup is
> opened (an alert message for example) is what should be used for the
> background shading in the highlighter.

Hrm, this seems like a good suggestion.

Comment 2

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 575880 [details] [diff] [review]
patch v1

I'm not sure that a noise pattern is a wise design choice for a page inspection tool... The veil needs to be distinguishable from the highlighted area, of course, but why go further than that?

r- since tabprompts-bgtexture.png is for tab-modal prompts and may arbitrarily change in the future. It's not supposed to be used in random other places.

Comment 4

[Paul Rouget [:paul]]

Attachment: patch v1.1 - no noise pattern

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/1718a8384382

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/1718a8384382