Note: There are a few cases of duplicates in user autocompletion which are being worked on.

requestAnimationFrame callback function name should be "sample", not "onBeforePaint"

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({addon-compat, dev-doc-needed})

Trunk
mozilla11
x86
Mac OS X
addon-compat, dev-doc-needed
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Per current draft at http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/RequestAnimationFrame/Overview.html
(Assignee)

Updated

6 years ago
Blocks: 704063
(Assignee)

Comment 1

6 years ago
https://mxr.mozilla.org/addons/search?string=onBeforePaint says we have no consumers of this in addons.  We do have some in our own tree.
Keywords: addon-compat
(Assignee)

Updated

6 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 2

6 years ago
I wonder whether I should rename nsIAnimationFrameListener to nsIFrameRequestCallback in the process...
(Assignee)

Comment 3

6 years ago
Created attachment 575895 [details] [diff] [review]
Rename onBeforePaint to sample for animation frame callbacks.
Attachment #575895 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Whiteboard: [need review]
Version: 9 Branch → Trunk
Attachment #575895 - Flags: review?(roc) → review+
Er, you need to rev the IID too.
(Assignee)

Comment 5

6 years ago
Hmm..  I guess I do to make JS that does iid-detection work.  :(  Will do.

Thoughts on comment 2?
Is iid rev really required? Method name change is binary compatible.
(Assignee)

Comment 7

6 years ago
"I guess I do to make JS that does iid-detection work".
(In reply to Boris Zbarsky (:bz) from comment #5)
> Thoughts on comment 2?

Seems like a good idea.
(Assignee)

Comment 9

6 years ago
OK, I'll add a patch to rename the interface, and change its iid at the same time.
(Assignee)

Updated

6 years ago
Blocks: 704171
(Assignee)

Comment 10

6 years ago
Created attachment 576541 [details] [diff] [review]
part 2.  Rename nsIAnimationFrameListener to nsIFrameRequestCallback.
Attachment #576541 - Flags: review?(roc)
Attachment #576541 - Flags: review?(roc) → review+
(Assignee)

Comment 11

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/befef8dfe35e
https://hg.mozilla.org/integration/mozilla-inbound/rev/e05a25fcfec6
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/befef8dfe35e
https://hg.mozilla.org/mozilla-central/rev/e05a25fcfec6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.