Last Comment Bug 704175 - requestAnimationFrame callback function name should be "sample", not "onBeforePaint"
: requestAnimationFrame callback function name should be "sample", not "onBefor...
Status: RESOLVED FIXED
: addon-compat, dev-doc-needed
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Boris Zbarsky [:bz]
:
Mentors:
Depends on:
Blocks: 704063 704171
  Show dependency treegraph
 
Reported: 2011-11-21 09:09 PST by Boris Zbarsky [:bz]
Modified: 2011-11-29 04:50 PST (History)
5 users (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Rename onBeforePaint to sample for animation frame callbacks. (4.17 KB, patch)
2011-11-21 09:52 PST, Boris Zbarsky [:bz]
roc: review+
Details | Diff | Review
part 2. Rename nsIAnimationFrameListener to nsIFrameRequestCallback. (19.27 KB, patch)
2011-11-23 10:35 PST, Boris Zbarsky [:bz]
roc: review+
Details | Diff | Review

Description Boris Zbarsky [:bz] 2011-11-21 09:09:55 PST
Per current draft at http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/RequestAnimationFrame/Overview.html
Comment 1 Boris Zbarsky [:bz] 2011-11-21 09:20:07 PST
https://mxr.mozilla.org/addons/search?string=onBeforePaint says we have no consumers of this in addons.  We do have some in our own tree.
Comment 2 Boris Zbarsky [:bz] 2011-11-21 09:28:02 PST
I wonder whether I should rename nsIAnimationFrameListener to nsIFrameRequestCallback in the process...
Comment 3 Boris Zbarsky [:bz] 2011-11-21 09:52:13 PST
Created attachment 575895 [details] [diff] [review]
Rename onBeforePaint to sample for animation frame callbacks.
Comment 4 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-11-21 12:46:28 PST
Er, you need to rev the IID too.
Comment 5 Boris Zbarsky [:bz] 2011-11-21 12:49:38 PST
Hmm..  I guess I do to make JS that does iid-detection work.  :(  Will do.

Thoughts on comment 2?
Comment 6 Masatoshi Kimura [:emk] 2011-11-21 14:33:46 PST
Is iid rev really required? Method name change is binary compatible.
Comment 7 Boris Zbarsky [:bz] 2011-11-21 14:37:49 PST
"I guess I do to make JS that does iid-detection work".
Comment 8 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-11-21 15:25:08 PST
(In reply to Boris Zbarsky (:bz) from comment #5)
> Thoughts on comment 2?

Seems like a good idea.
Comment 9 Boris Zbarsky [:bz] 2011-11-23 09:20:27 PST
OK, I'll add a patch to rename the interface, and change its iid at the same time.
Comment 10 Boris Zbarsky [:bz] 2011-11-23 10:35:28 PST
Created attachment 576541 [details] [diff] [review]
part 2.  Rename nsIAnimationFrameListener to nsIFrameRequestCallback.

Note You need to log in before you can comment on or make changes to this bug.