requestAnimationFrame callback function name should be "sample", not "onBeforePaint"

RESOLVED FIXED in mozilla11

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

({addon-compat, dev-doc-needed})

Trunk
mozilla11
x86
Mac OS X
addon-compat, dev-doc-needed
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Updated

7 years ago
Blocks: 704063
(Assignee)

Comment 1

7 years ago
https://mxr.mozilla.org/addons/search?string=onBeforePaint says we have no consumers of this in addons.  We do have some in our own tree.
Keywords: addon-compat
(Assignee)

Updated

7 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 2

7 years ago
I wonder whether I should rename nsIAnimationFrameListener to nsIFrameRequestCallback in the process...
(Assignee)

Comment 3

7 years ago
Created attachment 575895 [details] [diff] [review]
Rename onBeforePaint to sample for animation frame callbacks.
Attachment #575895 - Flags: review?(roc)
(Assignee)

Updated

7 years ago
Whiteboard: [need review]
Version: 9 Branch → Trunk
Er, you need to rev the IID too.
(Assignee)

Comment 5

7 years ago
Hmm..  I guess I do to make JS that does iid-detection work.  :(  Will do.

Thoughts on comment 2?
Is iid rev really required? Method name change is binary compatible.
(Assignee)

Comment 7

7 years ago
"I guess I do to make JS that does iid-detection work".
(In reply to Boris Zbarsky (:bz) from comment #5)
> Thoughts on comment 2?

Seems like a good idea.
(Assignee)

Comment 9

7 years ago
OK, I'll add a patch to rename the interface, and change its iid at the same time.
(Assignee)

Updated

7 years ago
Blocks: 704171
Created attachment 576541 [details] [diff] [review]
part 2.  Rename nsIAnimationFrameListener to nsIFrameRequestCallback.
Attachment #576541 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/befef8dfe35e
https://hg.mozilla.org/mozilla-central/rev/e05a25fcfec6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.