Closed
Bug 704175
Opened 12 years ago
Closed 12 years ago
requestAnimationFrame callback function name should be "sample", not "onBeforePaint"
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: addon-compat, dev-doc-needed)
Attachments
(2 files)
4.17 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
19.27 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Per current draft at http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/RequestAnimationFrame/Overview.html
![]() |
Assignee | |
Comment 1•12 years ago
|
||
https://mxr.mozilla.org/addons/search?string=onBeforePaint says we have no consumers of this in addons. We do have some in our own tree.
Keywords: addon-compat
![]() |
Assignee | |
Updated•12 years ago
|
Keywords: dev-doc-needed
![]() |
Assignee | |
Comment 2•12 years ago
|
||
I wonder whether I should rename nsIAnimationFrameListener to nsIFrameRequestCallback in the process...
![]() |
Assignee | |
Comment 3•12 years ago
|
||
Attachment #575895 -
Flags: review?(roc)
![]() |
Assignee | |
Updated•12 years ago
|
Whiteboard: [need review]
Version: 9 Branch → Trunk
Attachment #575895 -
Flags: review?(roc) → review+
Er, you need to rev the IID too.
![]() |
Assignee | |
Comment 5•12 years ago
|
||
Hmm.. I guess I do to make JS that does iid-detection work. :( Will do. Thoughts on comment 2?
Comment 6•12 years ago
|
||
Is iid rev really required? Method name change is binary compatible.
![]() |
Assignee | |
Comment 7•12 years ago
|
||
"I guess I do to make JS that does iid-detection work".
(In reply to Boris Zbarsky (:bz) from comment #5) > Thoughts on comment 2? Seems like a good idea.
![]() |
Assignee | |
Comment 9•12 years ago
|
||
OK, I'll add a patch to rename the interface, and change its iid at the same time.
![]() |
Assignee | |
Comment 10•12 years ago
|
||
Attachment #576541 -
Flags: review?(roc)
Attachment #576541 -
Flags: review?(roc) → review+
![]() |
Assignee | |
Comment 11•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/befef8dfe35e https://hg.mozilla.org/integration/mozilla-inbound/rev/e05a25fcfec6
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla11
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/befef8dfe35e https://hg.mozilla.org/mozilla-central/rev/e05a25fcfec6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•