704175 - requestAnimationFrame callback function name should be "sample", not "onBeforePaint"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Per current draft at http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/RequestAnimationFrame/Overview.html

Comment 1

[Boris Zbarsky [:bzbarsky]]

https://mxr.mozilla.org/addons/search?string=onBeforePaint says we have no consumers of this in addons.  We do have some in our own tree.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I wonder whether I should rename nsIAnimationFrameListener to nsIFrameRequestCallback in the process...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Rename onBeforePaint to sample for animation frame callbacks.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Er, you need to rev the IID too.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Hmm..  I guess I do to make JS that does iid-detection work.  :(  Will do.

Thoughts on comment 2?

Comment 6

[Masatoshi Kimura [:emk]]

Is iid rev really required? Method name change is binary compatible.

Comment 7

[Boris Zbarsky [:bzbarsky]]

"I guess I do to make JS that does iid-detection work".

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Boris Zbarsky (:bz) from comment #5)
> Thoughts on comment 2?

Seems like a good idea.

Comment 9

[Boris Zbarsky [:bzbarsky]]

OK, I'll add a patch to rename the interface, and change its iid at the same time.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Rename nsIAnimationFrameListener to nsIFrameRequestCallback.

Comment 11

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/befef8dfe35e
https://hg.mozilla.org/integration/mozilla-inbound/rev/e05a25fcfec6

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/befef8dfe35e
https://hg.mozilla.org/mozilla-central/rev/e05a25fcfec6