Last Comment Bug 704207 - HeapValue::gcKind should return JSGCTraceKind
: HeapValue::gcKind should return JSGCTraceKind
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Andrew McCreight [:mccr8]
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 668855
  Show dependency treegraph
Reported: 2011-11-21 10:38 PST by Andrew McCreight [:mccr8]
Modified: 2011-11-23 11:18 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

change the return type (1.14 KB, patch)
2011-11-21 16:26 PST, Andrew McCreight [:mccr8]
wmccloskey: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2011-11-21 10:38:30 PST
At least, I think.  Currently it returns unsigned.
Comment 1 [PTO to Dec5] Bill McCloskey (:billm) 2011-11-21 12:52:47 PST
Yes, I wrote the original code before JSGCTraceKind was added. Please feel free to fix, or else I'll do it in the incremental GC patch.
Comment 2 Andrew McCreight [:mccr8] 2011-11-21 16:26:54 PST
Created attachment 576024 [details] [diff] [review]
change the return type
Comment 3 [PTO to Dec5] Bill McCloskey (:billm) 2011-11-21 16:50:19 PST
Comment on attachment 576024 [details] [diff] [review]
change the return type

Comment 4 Andrew McCreight [:mccr8] 2011-11-23 06:17:53 PST
Comment 5 Matt Brubeck (:mbrubeck) 2011-11-23 10:13:43 PST

Note You need to log in before you can comment on or make changes to this bug.