Closed Bug 704394 Opened 8 years ago Closed 8 years ago

Spell checker thinks "quinoa" is a misspelling

Categories

(Core :: Spelling checker, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: dholbert, Assigned: sowmya.ravidas)

References

()

Details

(Whiteboard: [good first bug][mentor=ehsan])

Attachments

(4 files)

STEPS TO REPRODUCE:
 1. Visit http://pastebin.mozilla.org/
 2. Type "quinoa" into the text box

ACTUAL RESULTS: Squiggly red underline (misspelling)
EXPECTED RESULTS: No squiggly red underline.

My man Merriam-Webster backs me up:
 http://www.merriam-webster.com/dictionary/quinoa
as does the original, definitive source on the English language, NinjaWords:
  http://ninjawords.com/quinoa
Whiteboard: [good first bug][mentor=ehsan]
Assignee: nobody → sowmya.ravidas
I wrote up some documentation on how you can edit the en-US dictionary shipped with Firefox: <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary>.  Please let me know if you have any questions.
Attachment #592065 - Flags: review?(ehsan)
Comment on attachment 592065 [details] [diff] [review]
Word 'quinoa' added to dictionary

You should also overwrite the en-US.dic file in extensions/spellcheck/locales/en-US/hunspell with the one created in extensions/spellcheck/locales/en-US/hunspell/dictionary-sources.
Attachment #592065 - Flags: review?(ehsan)
Attached patch Patch modifiedSplinter Review
Attachment #592389 - Flags: review?(ehsan)
Comment on attachment 592389 [details] [diff] [review]
Patch modified

This looks great!  Thanks a lot, Sowmaya!
Attachment #592389 - Attachment is patch: true
Attachment #592389 - Flags: review?(ehsan) → review+
Hmm, wait.  There's one strange thing about the en-US.dic part of the patch.  The number at the beginning of the file should be incremented, but it's not.  Can you please update your Mercurial checkout (using hg revert -a --no-backup && hg pull -u) and rerun the steps in the document, and see if you get the number change at the beginning of en-US.dic inside the patch?  Thanks!
Whiteboard: [good first bug][mentor=ehsan] → [good first bug][mentor=ehsan][autoland]
Whiteboard: [good first bug][mentor=ehsan][autoland] → [good first bug][mentor=ehsan][autoland-in-queue]
Autoland Patchset:
	Patches: 592065, 592389
	Branch: mozilla-central => try
	Destination: ssh://hg.mozilla.org/try
Insufficient permissions to push to try
Whiteboard: [good first bug][mentor=ehsan][autoland-in-queue] → [good first bug][mentor=ehsan]
Attached patch patchSplinter Review
word count incremented
Attachment #600350 - Flags: review?(ehsan)
Comment on attachment 600350 [details] [diff] [review]
patch

Thanks.  Looks like you forgot to run merge-dictionaries as specified here? https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary  If this is done correctly, the en-US file should only have two changes, the word count increment and the introduction of quinoa.
Attachment #600350 - Attachment is patch: true
Attachment #600350 - Flags: review?(ehsan)
Attachment #603245 - Flags: review?(ehsan)
Comment on attachment 603245 [details] [diff] [review]
Word 'quinoa' added

Thanks a lot, looks great!
Attachment #603245 - Attachment is patch: true
Attachment #603245 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/4d086a890797

Thanks for the patch! :-)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.