704394 - Spell checker thinks "quinoa" is a misspelling

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 1. Visit http://pastebin.mozilla.org/
 2. Type "quinoa" into the text box

ACTUAL RESULTS: Squiggly red underline (misspelling)
EXPECTED RESULTS: No squiggly red underline.

My man Merriam-Webster backs me up:
 http://www.merriam-webster.com/dictionary/quinoa
as does the original, definitive source on the English language, NinjaWords:
  http://ninjawords.com/quinoa

Comment 1

[(no longer active)]

I wrote up some documentation on how you can edit the en-US dictionary shipped with Firefox: <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary>.  Please let me know if you have any questions.

Comment 2

[Sowmya R]

Attachment: Word 'quinoa' added to dictionary

Comment 3

[(no longer active)]

Comment on attachment 592065 [details] [diff] [review]
Word 'quinoa' added to dictionary

You should also overwrite the en-US.dic file in extensions/spellcheck/locales/en-US/hunspell with the one created in extensions/spellcheck/locales/en-US/hunspell/dictionary-sources.

Comment 4

[Sowmya R]

Attachment: Patch modified

Comment 5

[(no longer active)]

Comment on attachment 592389 [details] [diff] [review]
Patch modified

This looks great!  Thanks a lot, Sowmaya!

Comment 6

[(no longer active)]

Hmm, wait.  There's one strange thing about the en-US.dic part of the patch.  The number at the beginning of the file should be incremented, but it's not.  Can you please update your Mercurial checkout (using hg revert -a --no-backup && hg pull -u) and rerun the steps in the document, and see if you get the number change at the beginning of en-US.dic inside the patch?  Thanks!

Comment 7

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 592065, 592389
	Branch: mozilla-central => try
	Destination: ssh://hg.mozilla.org/try
Insufficient permissions to push to try

Comment 8

[Sowmya R]

Attachment: patch

word count incremented

Comment 9

[(no longer active)]

Comment on attachment 600350 [details] [diff] [review]
patch

Thanks.  Looks like you forgot to run merge-dictionaries as specified here? https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary  If this is done correctly, the en-US file should only have two changes, the word count increment and the introduction of quinoa.

Comment 10

[Sowmya R]

Attachment: Word 'quinoa' added

Comment 11

[(no longer active)]

Comment on attachment 603245 [details] [diff] [review]
Word 'quinoa' added

Thanks a lot, looks great!

Comment 12

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d086a890797

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4d086a890797

Thanks for the patch! :-)