Remove nsLayoutUtils::GetFrameFor

RESOLVED FIXED in mozilla12

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: jhk)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good_first_bug][mentor=Ms2ger])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
After bug 703260, it just wraps aView->GetFrame(), and there's only one consumer: <http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsContentEventHandler.cpp#813>.

Comment 1

6 years ago
I'm a systems engineer with c/c++ experience. I aware this is a code cleanup / refactoring exercise. But I want to get started.
(Reporter)

Comment 2

6 years ago
Hi!

The implementation is at <http://mxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.h#340>. Please do let me know if you need any help.

Comment 3

6 years ago
Thanks for the info Ms2ger ! Can I get some pointer / wiki related to the eventHandling, just to have a picture ?
(Reporter)

Comment 4

6 years ago
No idea myself, but smaug might have pointers.

Comment 5

6 years ago
Well, since the method is trivial, you can just copy its code to the only place it is used.

What kind of information about event handling is needed?
widget level code dispatches nsEvents to viewmanager/view which ends up to presshell which
calls nsEventStateManager. And between nsEventStateManager::PreHandleEvent and
PostHandleEvent event is dispatched to DOM.

Comment 6

6 years ago
@smaug: Thanks for the information.

I've started with the issue. I mostly work on Solaris10/Solaris11 x86. I'm currently trying to get a clean build for now. Will post a patch when done.
(Assignee)

Comment 7

6 years ago
Created attachment 586360 [details] [diff] [review]
Removed nsLayoutUtils::GetFrameFor.

Patch
Assignee: nobody → jigneshhk1992
Attachment #586360 - Flags: review?(Ms2ger)
(Assignee)

Comment 8

6 years ago
Created attachment 586361 [details] [diff] [review]
Removed nsLayoutUtils::GetFrameFor.

Patch2
Attachment #586360 - Attachment is obsolete: true
Attachment #586360 - Flags: review?(Ms2ger)
Attachment #586361 - Flags: review?(Ms2ger)
(Reporter)

Comment 9

6 years ago
Comment on attachment 586361 [details] [diff] [review]
Removed nsLayoutUtils::GetFrameFor.

Looks good to me, asking roc to sign off as well.
Attachment #586361 - Flags: superreview?(roc)
Attachment #586361 - Flags: review?(Ms2ger)
Attachment #586361 - Flags: review+
Attachment #586361 - Flags: superreview?(roc) → superreview+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a84838e8c98
Keywords: checkin-needed
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/6a84838e8c98

Thanks for the patch parthasarathy! Hope to see you on IRC in #developers soon :-)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.