704430 - Remove nsLayoutUtils::GetFrameFor

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

After bug 703260, it just wraps aView->GetFrame(), and there's only one consumer: <http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsContentEventHandler.cpp#813>.

Comment 1

[parthasarathy]

I'm a systems engineer with c/c++ experience. I aware this is a code cleanup / refactoring exercise. But I want to get started.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Hi!

The implementation is at <http://mxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.h#340>. Please do let me know if you need any help.

Comment 3

[parthasarathy]

Thanks for the info Ms2ger ! Can I get some pointer / wiki related to the eventHandling, just to have a picture ?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No idea myself, but smaug might have pointers.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Well, since the method is trivial, you can just copy its code to the only place it is used.

What kind of information about event handling is needed?
widget level code dispatches nsEvents to viewmanager/view which ends up to presshell which
calls nsEventStateManager. And between nsEventStateManager::PreHandleEvent and
PostHandleEvent event is dispatched to DOM.

Comment 6

[parthasarathy]

@smaug: Thanks for the information.

I've started with the issue. I mostly work on Solaris10/Solaris11 x86. I'm currently trying to get a clean build for now. Will post a patch when done.

Comment 7

[Jignesh Kakadiya [:jhk]]

Attachment: Removed nsLayoutUtils::GetFrameFor.

Patch

Comment 8

[Jignesh Kakadiya [:jhk]]

Attachment: Removed nsLayoutUtils::GetFrameFor.

Patch2

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 586361 [details] [diff] [review]
Removed nsLayoutUtils::GetFrameFor.

Looks good to me, asking roc to sign off as well.

Comment 10

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a84838e8c98

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6a84838e8c98

Thanks for the patch parthasarathy! Hope to see you on IRC in #developers soon :-)