Create telemetry probe to ascertain what proportion of users may prefer bug 695482's new 'open search in foreground' behaviour

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Menus
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: emorley, Assigned: dao)

Tracking

Trunk
Firefox 11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.85 KB, patch
Gavin
: review+
(dormant account)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #695482 +++

Bug 695482 changed the default for the context menu "Search Google for <selection>" such that the new tab now opens in the foreground. Replies in that bug indicate that this may be disruptive for certain workflows and that the change should either be backed out or an about:config pref added to allow the user to revert to the former behaviour.

In order to make a decision, it was suggested a telemetry probe be added to find out how many people (under the old behaviour) immediately switch to the new tab, after using the context menu search feature.

Assigning to Dao, per conversation on #developers. Thanks Dao! :-)
(Reporter)

Updated

6 years ago
Summary: Create telemetry probe to assertion what proportion of users may prefer bug 695482's new "Search Google for <selection>" in the foreground behaviour → Create telemetry probe to ascertain what proportion of users may prefer bug 695482's new 'open search in foreground' behaviour
This isn't worth it. Pick a default, make it possible for an add-on to do something else, and leave it at that. We have much more important things to fix. :)
(Assignee)

Comment 2

6 years ago
If you want us to pick the default arbitrarily, I'm leaning towards just reverting bug 695482, as it looks like there was no strong desire for this change while various people are annoyed by it. I don't think we should pick arbitrarily, as it shouldn't be too hard to get data.
(Assignee)

Comment 3

6 years ago
Created attachment 577253 [details] [diff] [review]
patch
Attachment #577253 - Flags: review?(tglek)
Attachment #577253 - Flags: review?(gavin.sharp)
(Assignee)

Updated

6 years ago
Component: Telemetry → Search
Product: Toolkit → Firefox
QA Contact: telemetry → search

Comment 4

6 years ago
What is MOZ_PHOENIX? Ie http://mxr.mozilla.org/mozilla/source/client.mk#658 true?
(Assignee)

Comment 5

6 years ago
MOZ_PHOENIX is set when building desktop Firefox (browser/). I don't think http://mxr.mozilla.org/mozilla/source/client.mk#658 is relevant here. http://mxr.mozilla.org/mozilla-central/source/client.mk doesn't deal with MOZ_PHOENIX at all.
(Assignee)

Comment 6

6 years ago
Created attachment 577601 [details] [diff] [review]
patch

updated to tip
Attachment #577253 - Attachment is obsolete: true
Attachment #577253 - Flags: review?(tglek)
Attachment #577253 - Flags: review?(gavin.sharp)
Attachment #577601 - Flags: review?(tglek)
Attachment #577601 - Flags: review?(gavin.sharp)
(Assignee)

Updated

6 years ago
Component: Search → Menus
QA Contact: search → menus

Comment 7

6 years ago
Comment on attachment 577601 [details] [diff] [review]
patch

r+ telemetry bits
Attachment #577601 - Flags: review?(tglek) → review+
Comment on attachment 577601 [details] [diff] [review]
patch

>diff --git a/toolkit/components/telemetry/TelemetryHistograms.h b/toolkit/components/telemetry/TelemetryHistograms.h

>+HISTOGRAM(FX_CONTEXT_SEARCH_AND_TAB_SELECT, 0, 1, 2, BOOLEAN, "Firefox: Background tab was selected after searching from the context menu")

maybe tweak this to mention "within 5 seconds of searching from the context menu"?
Attachment #577601 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/575d46b7119d
Target Milestone: --- → Firefox 11
(Reporter)

Comment 10

6 years ago
https://hg.mozilla.org/mozilla-central/rev/575d46b7119d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 710562
You need to log in before you can comment on or make changes to this bug.