704538 - Create telemetry probe to ascertain what proportion of users may prefer bug 695482's new 'open search in foreground' behaviour

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Ed Morley [:emorley]]

+++ This bug was initially created as a clone of Bug #695482 +++

Bug 695482 changed the default for the context menu "Search Google for <selection>" such that the new tab now opens in the foreground. Replies in that bug indicate that this may be disruptive for certain workflows and that the change should either be backed out or an about:config pref added to allow the user to revert to the former behaviour.

In order to make a decision, it was suggested a telemetry probe be added to find out how many people (under the old behaviour) immediately switch to the new tab, after using the context menu search feature.

Assigning to Dao, per conversation on #developers. Thanks Dao! :-)

Comment 1

[Alex Limi (:limi) — Firefox UX Team]

This isn't worth it. Pick a default, make it possible for an add-on to do something else, and leave it at that. We have much more important things to fix. :)

Comment 2

[Dão Gottwald [:dao]]

If you want us to pick the default arbitrarily, I'm leaning towards just reverting bug 695482, as it looks like there was no strong desire for this change while various people are annoyed by it. I don't think we should pick arbitrarily, as it shouldn't be too hard to get data.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[(dormant account)]

What is MOZ_PHOENIX? Ie http://mxr.mozilla.org/mozilla/source/client.mk#658 true?

Comment 5

[Dão Gottwald [:dao]]

MOZ_PHOENIX is set when building desktop Firefox (browser/). I don't think http://mxr.mozilla.org/mozilla/source/client.mk#658 is relevant here. http://mxr.mozilla.org/mozilla-central/source/client.mk doesn't deal with MOZ_PHOENIX at all.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

updated to tip

Comment 7

[(dormant account)]

Comment on attachment 577601 [details] [diff] [review]
patch

r+ telemetry bits

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 577601 [details] [diff] [review]
patch

>diff --git a/toolkit/components/telemetry/TelemetryHistograms.h b/toolkit/components/telemetry/TelemetryHistograms.h

>+HISTOGRAM(FX_CONTEXT_SEARCH_AND_TAB_SELECT, 0, 1, 2, BOOLEAN, "Firefox: Background tab was selected after searching from the context menu")

maybe tweak this to mention "within 5 seconds of searching from the context menu"?

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/575d46b7119d

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/575d46b7119d