Closed Bug 704666 Opened 8 years ago Closed 8 years ago

hunspell/README_en_US.txt and hunspell/README_mozilla.txt have DOS newline characters

Categories

(Core :: Spelling checker, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

These two files:
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/README_mozilla.txt
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/README_en_US.txt
have DOS newline characters at the end of each line.

emacs shows these characters in the former file, but not in the latter for some reason (possibly because the former file has a mix of newline characters whereas the latter is entirely-DOS)

Per https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide , the Mozilla codebase is standardized on Unix newline characters.

Patch coming up that converts the files, using the "fromdos" command-line utility (same as "dos2unix") on Ubuntu.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #576329 - Flags: review?(gavin.sharp)
Attachment #576329 - Flags: review?(gavin.sharp) → review+
Landed (as DONTBUILD):
 https://hg.mozilla.org/integration/mozilla-inbound/rev/6c56c78dc7a0
Severity: normal → trivial
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/6c56c78dc7a0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.