Closed
Bug 704666
Opened 13 years ago
Closed 13 years ago
hunspell/README_en_US.txt and hunspell/README_mozilla.txt have DOS newline characters
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
|
27.22 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
These two files:
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/README_mozilla.txt
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/README_en_US.txt
have DOS newline characters at the end of each line.
emacs shows these characters in the former file, but not in the latter for some reason (possibly because the former file has a mix of newline characters whereas the latter is entirely-DOS)
Per https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide , the Mozilla codebase is standardized on Unix newline characters.
Patch coming up that converts the files, using the "fromdos" command-line utility (same as "dos2unix") on Ubuntu.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•13 years ago
|
Attachment #576329 -
Flags: review?(gavin.sharp)
|
||
Updated•13 years ago
|
Attachment #576329 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Landed (as DONTBUILD):
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c56c78dc7a0
Severity: normal → trivial
Target Milestone: --- → mozilla11
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•