The default bug view has changed. See this FAQ.

hunspell/README_en_US.txt and hunspell/README_mozilla.txt have DOS newline characters

RESOLVED FIXED in mozilla11

Status

()

Core
Spelling checker
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
These two files:
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/README_mozilla.txt
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/README_en_US.txt
have DOS newline characters at the end of each line.

emacs shows these characters in the former file, but not in the latter for some reason (possibly because the former file has a mix of newline characters whereas the latter is entirely-DOS)

Per https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide , the Mozilla codebase is standardized on Unix newline characters.

Patch coming up that converts the files, using the "fromdos" command-line utility (same as "dos2unix") on Ubuntu.
(Assignee)

Comment 1

5 years ago
Created attachment 576329 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #576329 - Flags: review?(gavin.sharp)
Attachment #576329 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 2

5 years ago
Landed (as DONTBUILD):
 https://hg.mozilla.org/integration/mozilla-inbound/rev/6c56c78dc7a0
Severity: normal → trivial
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/6c56c78dc7a0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.