Closed Bug 704709 Opened 8 years ago Closed 8 years ago

Hardware volume buttons in full screen mode triggers full screen warning message

Categories

(Core :: DOM: Core & HTML, defect, major)

x86_64
Windows 7
defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla11
Tracking Status
firefox10 --- affected
firefox11 --- verified

People

(Reporter: asa, Assigned: cpearce)

References

Details

(Whiteboard: [good first bug][mentor=jwein][lang=c++][qa!])

Attachments

(1 file)

At YouTube's HTML5 video player, http://www.youtube.com/watch?v=JCUdy1nUqrg for example, if you go into fullscreen mode and then hit the hardware volume buttons on your laptop, the "Press ESC to leave Full-screen mode" UI returns. That UI should not return after initially disappearing. 

Tested on latest nightly build on a Thinkpad X1 laptop running Win 7 at this URL http://www.youtube.com/watch?v=JCUdy1nUqrg
Blocks: 545812
Component: Video/Audio → DOM: Core & HTML
QA Contact: video.audio → general
Guess we need to add those keys to the whitelist...
The changes to the whitelist should be made in layout/base/nsPresShell.cpp within the |IsFullScreenAndRestrictedKeyEvent| function.

We'll need to find out what the keyCode is for the hardware volume buttons.
Whiteboard: [good first bug][mentor=jwein][lang=cpp]
http://pearce.org.nz/full-screen/ displays keycode of pressed keys. On my Win7 Lenovo T510 mute is 173, volume-down is 174, volume up is 175. I'm not sure if the same key codes are used on other platforms or even other hardware vendors on windows.
I have the same key codes (although my laptop is very similar: Lenovo W520 Win7)
Whiteboard: [good first bug][mentor=jwein][lang=cpp] → [good first bug][mentor=jwein][lang=c++]
(In reply to Chris Pearce (:cpearce) (Mozilla Corporation) from comment #3)
> http://pearce.org.nz/full-screen/ displays keycode of pressed keys. On my
> Win7 Lenovo T510 mute is 173, volume-down is 174, volume up is 175. I'm not
> sure if the same key codes are used on other platforms or even other
> hardware vendors on windows.

Some on my old Samsung NC10 netbook on Windows XP.
(In reply to Dão Gottwald [:dao] from comment #5)
> (In reply to Chris Pearce (:cpearce) (Mozilla Corporation) from comment #3)
> > http://pearce.org.nz/full-screen/ displays keycode of pressed keys. On my
> > Win7 Lenovo T510 mute is 173, volume-down is 174, volume up is 175. I'm not
> > sure if the same key codes are used on other platforms or even other
> > hardware vendors on windows.
> 
> Some on my old Samsung NC10 netbook on Windows XP.

s/Some/Same/
The hardware volume control keys don't make it through to content on MacOSX and on Fedora Core 15 Linux. I'm not sure about other Linux distros/window managers, so I'll assume this is windows-only for now.
Assignee: nobody → chris
Status: NEW → ASSIGNED
Summary: using hardware volume buttons in full screen mode on YouTube HTML5 video triggers the UI for escaping full screen → Hardware volume buttons in full screen mode triggers full screen warning message
Attached patch PatchSplinter Review
Don't show the full-screen warning when pressing media volume keys on Windows.
Attachment #577814 - Flags: review?(bugs)
(In reply to Chris Pearce (:cpearce) (Mozilla Corporation) from comment #8)
> The hardware volume control keys don't make it through to content on MacOSX
> and on Fedora Core 15 Linux.
Yeah, I haven't managed to get events from volume control keys on Fedora.
Attachment #577814 - Flags: review?(jmathies)
Attachment #577814 - Flags: review?(bugs)
Attachment #577814 - Flags: review+
Attachment #577814 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/72e787c04eb6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=jwein][lang=c++] → [good first bug][mentor=jwein][lang=c++][qa+]
Verified as fixed using a Windows 7 64-bit MacBook Air with:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0

The "Press ESC to leave Full-screen mode" message is not displayed anymore when changing the volume from the keyboard.
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug][mentor=jwein][lang=c++][qa+] → [good first bug][mentor=jwein][lang=c++][qa!]
Also verified as fixed using a Windows 7 64-bit HP Compaq 6715b with:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0 beta 3. 

I changed volume by using the specific volume keys from this laptop but the issue didn't reproduce anymore.
You need to log in before you can comment on or make changes to this bug.