Last Comment Bug 704735 - _state is not initialized in Android-MessagePumpForUI ctor
: _state is not initialized in Android-MessagePumpForUI ctor
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: mozilla11
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-22 20:22 PST by Oleg Romashin (:romaxa)
Modified: 2011-11-28 05:19 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Initialize state_ member in ctor for android pump (746 bytes, patch)
2011-11-22 20:25 PST, Oleg Romashin (:romaxa)
no flags Details | Diff | Review
Initialize state_ member in ctor for android pump (744 bytes, patch)
2011-11-22 21:11 PST, Oleg Romashin (:romaxa)
cjones.bugs: review+
Details | Diff | Review

Description Oleg Romashin (:romaxa) 2011-11-22 20:22:59 PST
Tried to startup message pump for android-non-xpcom UI process and immediately got crash
0x72ecb716 in base::MessagePumpForUI::Run (this=0x50813360, delegate=0xbe9b2240)
    at ipc/chromium/src/base/message_pump_android.cc:43
43	  state.run_depth = state_ ? state_->run_depth + 1 : 1;
(gdb) bt
#0  0x72ecb716 in base::MessagePumpForUI::Run (this=0x50813360, delegate=0xbe9b2240)
    at ipc/chromium/src/base/message_pump_android.cc:43
#1  0x72ea77ea in MessageLoop::RunInternal (this=0xbe9b2240)
    at ipc/chromium/src/base/message_loop.cc:208
#2  0x72ea784a in RunHandler (this=<optimized out>)
    at ipc/chromium/src/base/message_loop.cc:201
#3  MessageLoop::Run (this=0xbe9b2240)
    at ipc/chromium/src/base/message_loop.cc:175
#4  0x72271f9a in XRE_InitIPCEmbedding (aArgc=3, aArgv=<optimized out>, aListener=0x5080d0f0)

(gdb) p state_
$1 = (base::MessagePumpForUI::RunState *) 0xa5a5a5a5
Comment 1 Oleg Romashin (:romaxa) 2011-11-22 20:25:11 PST
Created attachment 576394 [details] [diff] [review]
Initialize state_ member in ctor for android pump
Comment 2 Oleg Romashin (:romaxa) 2011-11-22 21:11:46 PST
Created attachment 576398 [details] [diff] [review]
Initialize state_ member in ctor for android pump

This should be better
Comment 4 Marco Bonardo [::mak] 2011-11-28 05:19:25 PST
https://hg.mozilla.org/mozilla-central/rev/f8a52c83480a

Note You need to log in before you can comment on or make changes to this bug.