_state is not initialized in Android-MessagePumpForUI ctor

RESOLVED FIXED in mozilla11

Status

()

Core
IPC
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla11
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Tried to startup message pump for android-non-xpcom UI process and immediately got crash
0x72ecb716 in base::MessagePumpForUI::Run (this=0x50813360, delegate=0xbe9b2240)
    at ipc/chromium/src/base/message_pump_android.cc:43
43	  state.run_depth = state_ ? state_->run_depth + 1 : 1;
(gdb) bt
#0  0x72ecb716 in base::MessagePumpForUI::Run (this=0x50813360, delegate=0xbe9b2240)
    at ipc/chromium/src/base/message_pump_android.cc:43
#1  0x72ea77ea in MessageLoop::RunInternal (this=0xbe9b2240)
    at ipc/chromium/src/base/message_loop.cc:208
#2  0x72ea784a in RunHandler (this=<optimized out>)
    at ipc/chromium/src/base/message_loop.cc:201
#3  MessageLoop::Run (this=0xbe9b2240)
    at ipc/chromium/src/base/message_loop.cc:175
#4  0x72271f9a in XRE_InitIPCEmbedding (aArgc=3, aArgv=<optimized out>, aListener=0x5080d0f0)

(gdb) p state_
$1 = (base::MessagePumpForUI::RunState *) 0xa5a5a5a5
(Assignee)

Comment 1

6 years ago
Created attachment 576394 [details] [diff] [review]
Initialize state_ member in ctor for android pump
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #576394 - Flags: review?(jones.chris.g)
(Assignee)

Comment 2

6 years ago
Created attachment 576398 [details] [diff] [review]
Initialize state_ member in ctor for android pump

This should be better
Attachment #576394 - Attachment is obsolete: true
Attachment #576394 - Flags: review?(jones.chris.g)
Attachment #576398 - Flags: review?(jones.chris.g)
Attachment #576398 - Flags: review?(jones.chris.g) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/f8a52c83480a
Keywords: checkin-needed
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/f8a52c83480a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.