70481 - need to get rid of isModal, isWindowModal redundancy

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Judson Valeski]

We still have this dual world we need to reconcile. Dan points out this ugly
redundancy:

nsIDocShellTreeOwner  nsIWebBrowserChrome
isModal               isWindowModal
showModal             showAsModal
exitModalLoop         exitModalEventLoop

Comment 1

[Peter Trudelle]

->moz0.9

Comment 2

[Dan M]

Attachment: remove the three modal... methods from nsIDocShellTreeOwner

Comment 3

[Conrad Carlen (not reading bugmail)]

The patch makes it a lot cleaner.
r=ccarlen 

Comment 4

[Dan M]

.

Comment 5

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 6

[David Epstein]

* isModal(), showModal() and exitModalLoop() removed from nsIDocShellTreeOwner
* showAsModal(), isWindowModal() and exitModalEventLoop() are found in 
nsIWebBrowserChrome.
* per contents of the patch: 
- the 3 nsIDocShellTreeOwner modals are not implemented in any of these: 
nsIDocShellTreeOwner.cpp, nsWindowWatcher.cpp, nsSyncLoader.cpp, 
nsXMLHttpRequest.cpp, nsPrefMigration.cpp, nsChromeTreeOwner.cpp, and 
WebBrowserChrome.cpp (couldn't find GtkMozEmbedChrome.cpp. is this obsolete?)
- nsContentTreeOwner.cpp uses ShowModal() (line 392) and exitModalLoop (line 
403), but these are returned from a XUL Window within implementations of 
showAsModal() and exitModalEventLoop() respectively.