Last Comment Bug 704820 - Simplify nsContentUtils::ReportToConsole
: Simplify nsContentUtils::ReportToConsole
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla11
Assigned To: Masatoshi Kimura [:emk]
: Andrew Overholt [:overholt]
Depends on: 701787
  Show dependency treegraph
Reported: 2011-11-23 06:44 PST by Masatoshi Kimura [:emk]
Modified: 2012-02-01 14:00 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (55.34 KB, patch)
2011-11-23 06:47 PST, Masatoshi Kimura [:emk]
no flags Details | Diff | Splinter Review
patch (55.39 KB, patch)
2011-11-29 06:03 PST, Masatoshi Kimura [:emk]
bugs: review+
Details | Diff | Splinter Review
Simplify nsContentUtils::ReportToConsole. r=smaug (56.49 KB, patch)
2011-12-09 10:21 PST, Masatoshi Kimura [:emk]
VYV03354: review+
Details | Diff | Splinter Review

Description User image Masatoshi Kimura [:emk] 2011-11-23 06:44:39 PST
Most callers do not set params, paramsLength, URI, source, lineNumber.
columnNumber is not used at all!
Most callers do not set non-zero windowID.
So I propose the follwing changes:
- Move flags, category and doc params onto other rarer used params and make the rest params optional.
- Remove the windowID version method.
Comment 1 User image Masatoshi Kimura [:emk] 2011-11-23 06:47:32 PST
Created attachment 576481 [details] [diff] [review]
Comment 2 User image Masatoshi Kimura [:emk] 2011-11-23 06:50:44 PST
Apply this on top of bug 701787's patch.
Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2011-11-23 06:54:41 PST
Looks like the only caller that passes a raw window ID is the nsIDOMWindowInternal one, so it's probably fine to remove that variant.
Comment 4 User image Masatoshi Kimura [:emk] 2011-11-29 06:03:42 PST
Created attachment 577582 [details] [diff] [review]

Updated to tip
Comment 5 User image Dão Gottwald [:dao] 2011-11-29 08:21:35 PST
Please mark this for check-in once the dependencies are cleared.
Comment 6 User image Masatoshi Kimura [:emk] 2011-12-09 10:21:18 PST
Created attachment 580453 [details] [diff] [review]
Simplify nsContentUtils::ReportToConsole. r=smaug

Updated to tip
Comment 7 User image Masatoshi Kimura [:emk] 2011-12-09 10:22:02 PST
The dependent bug has been fixed.
Comment 8 User image Ed Morley [:emorley] 2011-12-15 02:34:12 PST
In my queue with a few other checkin-neededs that are being sent to try first and then onto inbound :-)
Comment 10 User image Ed Morley [:emorley] 2011-12-16 06:19:23 PST

Note You need to log in before you can comment on or make changes to this bug.