Simplify nsContentUtils::ReportToConsole

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Most callers do not set params, paramsLength, URI, source, lineNumber.
columnNumber is not used at all!
Most callers do not set non-zero windowID.
So I propose the follwing changes:
- Move flags, category and doc params onto other rarer used params and make the rest params optional.
- Remove the windowID version method.
(Assignee)

Comment 1

6 years ago
Created attachment 576481 [details] [diff] [review]
patch
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #576481 - Flags: review?(bugs)
(Assignee)

Comment 2

6 years ago
Apply this on top of bug 701787's patch.
Depends on: 701787
Looks like the only caller that passes a raw window ID is the nsIDOMWindowInternal one, so it's probably fine to remove that variant.
(Assignee)

Comment 4

6 years ago
Created attachment 577582 [details] [diff] [review]
patch

Updated to tip
Attachment #576481 - Attachment is obsolete: true
Attachment #576481 - Flags: review?(bugs)
Attachment #577582 - Flags: review?(bugs)

Updated

6 years ago
Attachment #577582 - Flags: review?(bugs) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Please mark this for check-in once the dependencies are cleared.
Keywords: checkin-needed
(Assignee)

Comment 6

5 years ago
Created attachment 580453 [details] [diff] [review]
Simplify nsContentUtils::ReportToConsole. r=smaug

Updated to tip
Attachment #577582 - Attachment is obsolete: true
Attachment #580453 - Flags: review+
(Assignee)

Comment 7

5 years ago
The dependent bug has been fixed.
Keywords: checkin-needed

Comment 8

5 years ago
In my queue with a few other checkin-neededs that are being sent to try first and then onto inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=fd440327d5e4
Keywords: checkin-needed

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8659eb419fb
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/e8659eb419fb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.