Last Comment Bug 704832 - GCLI echo command causes a parse error on the console
: GCLI echo command causes a parse error on the console
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 11
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
Depends on:
Blocks: GCLI-SHIP
  Show dependency treegraph
 
Reported: 2011-11-23 07:49 PST by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2011-12-08 21:31 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
upload 1 (179 bytes, patch)
2011-12-02 05:57 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
no flags Details | Diff | Splinter Review
upload 2 (7.23 KB, patch)
2011-12-05 03:44 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
dcamp: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-11-23 07:49:44 PST
hint generation is treating the input as XHTML, which is a mistake
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-02 05:57:25 PST
Created attachment 578561 [details] [diff] [review]
upload 1

a.k.a. https://github.com/campd/gcli/pull/9
Comment 2 Dave Camp (:dcamp) 2011-12-02 11:00:46 PST
This patch is empty (but I reviewed the pull request).
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-05 03:44:27 PST
Created attachment 579025 [details] [diff] [review]
upload 2


This patch adds:
* Actual code.
* Minor review comment fix:
  https://github.com/joewalker/gcli/commit/e0d85e92f4c111cf231f548ec2a714e0c9c8d0fe
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-05 03:56:42 PST
https://tbpl.mozilla.org/?tree=Try&rev=2444a569f2c7
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-08 06:05:51 PST
https://tbpl.mozilla.org/?tree=Fx-Team&rev=cf3ed4316481
Comment 6 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2011-12-08 21:31:14 PST
https://hg.mozilla.org/mozilla-central/rev/21c1c224cf96

Note You need to log in before you can comment on or make changes to this bug.