Closed Bug 704841 Opened 10 years ago Closed 10 years ago
_jscontext for Components .utils getters
There's a // FIXME/bug 671453: work around broken [implicit_jscontext] comment, but bug 671453 has been fixed. Let's use it.
Relevant code: http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/xpccomponents.idl#321 http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCComponents.cpp#4053 All of the attributes in nsIXPCComponents_Utils should have the implicit_jscontext attribute added. The getters and setters generated by the macros in the C++ file will then get a JSContext* parameter added to them, which should be used instead of the GetJSContext function they currently call.
Whiteboard: [mentor=jdm] [lang=c++]
Comment on attachment 578254 [details] [diff] [review] Patch Nice!
Comment on attachment 578254 [details] [diff] [review] Patch Looks good! r=bholley
Attachment #578254 - Flags: review?(bobbyholley+bmo) → review+
Assignee: nobody → reuben.morais
Target Milestone: --- → mozilla11
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.