Use implicit_jscontext for Components.utils getters

RESOLVED FIXED in mozilla11

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: reuben)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jdm] [lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
There's a
  // FIXME/bug 671453: work around broken [implicit_jscontext]
comment, but bug 671453 has been fixed. Let's use it.

Comment 1

6 years ago
Relevant code:
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/xpccomponents.idl#321
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCComponents.cpp#4053

All of the attributes in nsIXPCComponents_Utils should have the implicit_jscontext attribute added. The getters and setters generated by the macros in the C++ file will then get a JSContext* parameter added to them, which should be used instead of the GetJSContext function they currently call.
Whiteboard: [mentor=jdm] [lang=c++]
(Assignee)

Comment 2

6 years ago
Created attachment 578254 [details] [diff] [review]
Patch
Attachment #578254 - Flags: feedback?(josh)

Comment 3

6 years ago
Comment on attachment 578254 [details] [diff] [review]
Patch

Nice!
Attachment #578254 - Flags: review?(bobbyholley+bmo)
Attachment #578254 - Flags: feedback?(josh)
Attachment #578254 - Flags: feedback+
Comment on attachment 578254 [details] [diff] [review]
Patch

Looks good! r=bholley
Attachment #578254 - Flags: review?(bobbyholley+bmo) → review+

Updated

6 years ago
Assignee: nobody → reuben.morais
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/8d316e7fd4b0
Keywords: checkin-needed
Target Milestone: --- → mozilla11

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8d316e7fd4b0
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.