Closed
Bug 704841
Opened 13 years ago
Closed 13 years ago
Use implicit_jscontext for Components.utils getters
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: reuben)
Details
(Whiteboard: [mentor=jdm] [lang=c++])
Attachments
(1 file)
|
3.89 KB,
patch
|
bholley
:
review+
jdm
:
feedback+
|
Details | Diff | Splinter Review |
There's a
// FIXME/bug 671453: work around broken [implicit_jscontext]
comment, but bug 671453 has been fixed. Let's use it.
|
||
Comment 1•13 years ago
|
||
Relevant code:
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/xpccomponents.idl#321
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCComponents.cpp#4053
All of the attributes in nsIXPCComponents_Utils should have the implicit_jscontext attribute added. The getters and setters generated by the macros in the C++ file will then get a JSContext* parameter added to them, which should be used instead of the GetJSContext function they currently call.
Whiteboard: [mentor=jdm] [lang=c++]
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #578254 -
Flags: feedback?(josh)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 578254 [details] [diff] [review]
Patch
Nice!
Attachment #578254 -
Flags: review?(bobbyholley+bmo)
Attachment #578254 -
Flags: feedback?(josh)
Attachment #578254 -
Flags: feedback+
|
||
Comment 4•13 years ago
|
||
Comment on attachment 578254 [details] [diff] [review]
Patch
Looks good! r=bholley
Attachment #578254 -
Flags: review?(bobbyholley+bmo) → review+
|
|
||
Updated•13 years ago
|
Assignee: nobody → reuben.morais
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla11
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•