Last Comment Bug 705009 - DeviceMotion accelerationIncludingGravity values are in units of "G"s
: DeviceMotion accelerationIncludingGravity values are in units of "G"s
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: unspecified
: ARM Android
: -- normal (vote)
: mozilla11
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
:
Mentors:
http://dev.w3.org/geo/api/spec-source...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-23 16:25 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2011-11-28 05:25 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Report DeviceMotion values in units of m/s^2, not Gs, per current spec (1.32 KB, patch)
2011-11-23 16:28 PST, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
doug.turner: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-11-23 16:25:33 PST
The current spec says they should be in units of m/s^2, but they're currently reported as fractional multiples of 1G.  I'm not sure what happens on other platforms.  We should do what the spec says.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-11-23 16:28:56 PST
Created attachment 576649 [details] [diff] [review]
Report DeviceMotion values in units of m/s^2, not Gs, per current spec
Comment 2 Doug Turner (:dougt) 2011-11-23 19:37:23 PST
Comment on attachment 576649 [details] [diff] [review]
Report DeviceMotion values in units of m/s^2, not Gs, per current spec

Review of attachment 576649 [details] [diff] [review]:
-----------------------------------------------------------------

this is fine, thanks!  could you also make sure that the absolute property of DeviceOrientationEvent is |true|?
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-11-26 18:48:27 PST
It's set to true unconditionally at http://mxr.mozilla.org/mozilla-central/source/dom/system/nsDeviceMotion.cpp#275, the only site I found.  I don't know whether the data is absolute per spec or not.
Comment 5 Marco Bonardo [::mak] 2011-11-28 05:25:17 PST
https://hg.mozilla.org/mozilla-central/rev/601d585e1e35

Note You need to log in before you can comment on or make changes to this bug.