705011 - tests failing in test-xhr since undefined options merge

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

Four tests are failing in test-xhr since the "undefined options" merge:

https://tbpl.mozilla.org/?tree=Jetpack&usetinderbox=1&rev=52fd4dc4e77d

The builds appear green because of bug 704708, but they're actually failing with:

error: TEST FAILED: test-xhr.testAbortedXhr (failure)
error: fail: 1 != 0
info: Traceback (most recent call last):
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/timer.js", line 66, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 289, in null
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 437, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 459, in start
    this.test.testFunction(this);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test-finder.js", line 56, in runTest
    test(runner);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-tests/test-xhr.js", line 9, in null
    test.assertEqual(xhr.getRequestCount(), 0);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 192, in assertEqual
    this.fail(message);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 99, in fail
    this.console.trace();
error: TEST FAILED: test-xhr.testDelegatedReturns (failure)
error: fail: 2 != 1
info: Traceback (most recent call last):
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/timer.js", line 66, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 289, in null
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 437, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 459, in start
    this.test.testFunction(this);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test-finder.js", line 56, in runTest
    test(runner);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-tests/test-xhr.js", line 65, in null
    test.assertEqual(xhr.getRequestCount(), 1);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 192, in assertEqual
    this.fail(message);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 99, in fail
    this.console.trace();
.error: TEST FAILED: test-xhr.testLocalXhr (failure)
error: fail: 2 != 1
info: Traceback (most recent call last):
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/timer.js", line 66, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 289, in null
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 437, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 459, in start
    this.test.testFunction(this);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test-finder.js", line 56, in runTest
    test(runner);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-tests/test-xhr.js", line 29, in null
    test.assertEqual(xhr.getRequestCount(), 1);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 192, in assertEqual
    this.fail(message);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 99, in fail
    this.console.trace();
.error: fail: 1 != 0
info: Traceback (most recent call last):
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/timer.js", line 66, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-tests/test-xhr.js", line 22, in null
    function() { test.assertEqual(xhr.getRequestCount(), 0);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 192, in assertEqual
    this.fail(message);
  File "resource://b41012c7-feec-4b00-bb23-bbdfe7585ddb-at-jetpack-api-utils-lib/unit-test.js", line 99, in fail
    this.console.trace();

Comment 1

[Myk Melez [:myk] [@mykmelez]]

This is really important to fix, since it is causing test failures on all mozilla-central test runs:

https://tbpl.mozilla.org/?tree=Jetpack&usetinderbox=1

We either need to fix this or back out the change that caused the regression.

Irakli: can you investigate?

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

It looks like change mentioned by @myk does not causes regression it just fixes bug that was incorrectly reporting test failures as passes. So change just reflected failures failures onto tinderbox.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

There is only one test that fails on nightly because of the platform bug 707256, all the following xhr tests fail just because number of open requests get's messed up by one failing test. I'll write patch to disable this test until platform bug is fixed.

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/285

Pointer to Github pull-request

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/73726328fed0ebc7adafc800d69b4bf2c468ab27
Merge pull request #285 from Gozala/bug/xhr.test-705011

fix Bug 705011 - Disable failing XHR test until platform bug 707256 is fixed. r=@mykmelez