Closed Bug 705141 Opened 12 years ago Closed 12 years ago

Fix my silly typos in SuiteBrowser.manifest

Categories

(SeaMonkey :: Startup & Profiles, defect)

Product:
SeaMonkey
Component:
Startup & Profiles
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.2 wontfix, seamonkey2.3 wontfix, seamonkey2.5 affected, seamonkey2.6 fixed, seamonkey2.7 fixed, seamonkey2.8 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.6
Tracking Flags:
Tracking Status
seamonkey2.2 --- wontfix
seamonkey2.3 --- wontfix
seamonkey2.5 --- affected
seamonkey2.6 --- fixed
seamonkey2.7 --- fixed
seamonkey2.8 --- fixed

People

(Reporter: neil, Assigned: mcsmurf)

References

Details

(Keywords: helpwanted, regression, Whiteboard: [mentor=Neil])

Attachments

(1 file)

Patch
4.25 KB, patch
neil
: review+
neil
: approval-comm-aurora+
neil
: approval-comm-beta+
Details | Diff | Splinter Review 
When I created SuiteBrowser.manifest I copied and pasted 16 lines from compreg.dat but unfortunately when I reformatted the lines from compreg.dat format to manifest format I accidentally left some stray double quote characters which interfere with the operation of the file :-(
Oh, and here's the test case.

1. Either
   1a. Configure links from external applications to open in new windows
   Or
   1b. Close all browser windows
2. Open Help
3. Try clicking on an external link

This should open a browser window, but it tries to download instead.
Attached patch Patch — — Splinter Review 
Assignee: nobody → bugzilla

        Attachment #576791 -
        Flags: review?(neil)

    
  

        Attachment #576791 -
        Flags: review?(neil)

        Attachment #576791 -
        Flags: review+

        Attachment #576791 -
        Flags: approval-comm-beta+

        Attachment #576791 -
        Flags: approval-comm-aurora+

    
    

    
  
Hmm, seems we're missing a status-seamonkey2.4 flag. :-/
Status: NEW → ASSIGNED

          status-seamonkey2.2:
          affected → wontfix

          status-seamonkey2.3:
          affected → wontfix

    
    

    
  
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/06c532c43f91
Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/beb64265e998
Pushed to comm-beta:
http://hg.mozilla.org/releases/comm-beta/rev/afdd55bc88bd
Missed cut-off for 2.6b2. Will only make SeaMonkey 2.6b3. See:
http://hg.mozilla.org/releases/comm-beta/graph/9392
Status: ASSIGNED → RESOLVED
Closed: 12 years ago

          status-seamonkey2.6:
          affected → fixed

          status-seamonkey2.7:
          affected → fixed

          status-seamonkey2.8:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6

          You need to log in
          before you can comment on or make changes to this bug.