Closed Bug 705145 Opened 14 years ago Closed 14 years ago

Multiple selection lists cannot be scrolled

Categories

(Firefox for Android Graveyard :: General, defect, P2)

ARM
Android
defect

Tracking

(firefox11 fixed, fennec11+)

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: xti, Assigned: wesj)

Details

Attachments

(1 file, 1 obsolete file)

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111124 Firefox/11.0a1 Fennec/11.0a1 Devices: Samsung Galaxy Nexus S OS: Android 2.3.4 Steps to reproduce: 1. Open Fennec App 2. Browse to bugzilla.mozilla.org 3. Tap on Search button > Advance search 4. Scroll down the "Product" multi-selection list Expected result: The "Product" list is scrollable. Actual result: The "Product" list cannot be scrolled. There will be the same results for any other multi-selection list.
Assignee: nobody → wjohnston
Priority: -- → P2
Attached patch Patch (obsolete) — Splinter Review
Add these to the list of scrollable things.
Attachment #580388 - Flags: review?(mark.finkle)
Comment on attachment 580388 [details] [diff] [review] Patch I know this bug is about multiple select listboxes (<select size='1' multiple='1'/>), but should this really be about _any_ listbox (<select size='1'/>) ?
Attached patch PatchSplinter Review
Oh good catch. This scrolls multiple selects and selects with size > 1. Test page: http://dl.dropbox.com/u/72157/Testing/Select.html
Attachment #580388 - Attachment is obsolete: true
Attachment #580388 - Flags: review?(mark.finkle)
Attachment #580409 - Flags: review?(mark.finkle)
Attachment #580409 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 580409 [details] [diff] [review] Patch >--- a/mobile/android/chrome/content/browser.js >+++ b/mobile/android/chrome/content/browser.js >- elem.localName == 'textarea' || >- elem.localName == 'html' || >- elem.localName == 'body')) { >+ elem.mozMatchesSelector("html, body, textarea")) || Why?
(In reply to Ms2ger from comment #6) > Comment on attachment 580409 [details] [diff] [review] > Patch > > >--- a/mobile/android/chrome/content/browser.js > >+++ b/mobile/android/chrome/content/browser.js > >- elem.localName == 'textarea' || > >- elem.localName == 'html' || > >- elem.localName == 'body')) { > >+ elem.mozMatchesSelector("html, body, textarea")) || > > Why? I assumed it was simply cleanup of an already "out of control" it statement. Are you concerned about performance?
(In reply to Mark Finkle (:mfinkle) from comment #7) > (In reply to Ms2ger from comment #6) > > Comment on attachment 580409 [details] [diff] [review] > > Patch > > > > >--- a/mobile/android/chrome/content/browser.js > > >+++ b/mobile/android/chrome/content/browser.js > > >- elem.localName == 'textarea' || > > >- elem.localName == 'html' || > > >- elem.localName == 'body')) { > > >+ elem.mozMatchesSelector("html, body, textarea")) || > > > > Why? > > I assumed it was simply cleanup of an already "out of control" it statement. > Are you concerned about performance? Not too much, just wondering.
Retested with: Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111212 Firefox/11.0a1 Fennec/11.0a1 HTC Desire Z (Android 2.3) Bug no longer reproducible. All lists from http://dl.dropbox.com/u/72157/Testing/Select.html can be scrolled properly. Verifying bug.
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: