705145 - Multiple selection lists cannot be scrolled

Status: VERIFIED FIXED

(Firefox for Android :: General, defect, P2)

Description

[Cristian Nicolae (:xti)]

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111124
Firefox/11.0a1 Fennec/11.0a1
Devices: Samsung Galaxy Nexus S
OS: Android 2.3.4

Steps to reproduce:
1. Open Fennec App
2. Browse to bugzilla.mozilla.org
3. Tap on Search button > Advance search
4. Scroll down the "Product" multi-selection list

Expected result:
The "Product" list is scrollable.

Actual result:
The "Product" list cannot be scrolled. There will be the same results for any other multi-selection list.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Add these to the list of scrollable things.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 580388 [details] [diff] [review]
Patch

I know this bug is about multiple select listboxes (<select size='1' multiple='1'/>), but should this really be about _any_ listbox (<select size='1'/>) ?

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

Oh good catch. This scrolls multiple selects and selects with size > 1. Test page:

http://dl.dropbox.com/u/72157/Testing/Select.html

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a64d8d8b512e

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a64d8d8b512e

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 580409 [details] [diff] [review]
Patch

>--- a/mobile/android/chrome/content/browser.js
>+++ b/mobile/android/chrome/content/browser.js
>-             elem.localName == 'textarea' ||
>-             elem.localName == 'html' ||
>-             elem.localName == 'body')) {
>+             elem.mozMatchesSelector("html, body, textarea")) ||

Why?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ms2ger from comment #6)
> Comment on attachment 580409 [details] [diff] [review]
> Patch
> 
> >--- a/mobile/android/chrome/content/browser.js
> >+++ b/mobile/android/chrome/content/browser.js
> >-             elem.localName == 'textarea' ||
> >-             elem.localName == 'html' ||
> >-             elem.localName == 'body')) {
> >+             elem.mozMatchesSelector("html, body, textarea")) ||
> 
> Why?

I assumed it was simply cleanup of an already "out of control" it statement. Are you concerned about performance?

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Mark Finkle (:mfinkle) from comment #7)
> (In reply to Ms2ger from comment #6)
> > Comment on attachment 580409 [details] [diff] [review]
> > Patch
> > 
> > >--- a/mobile/android/chrome/content/browser.js
> > >+++ b/mobile/android/chrome/content/browser.js
> > >-             elem.localName == 'textarea' ||
> > >-             elem.localName == 'html' ||
> > >-             elem.localName == 'body')) {
> > >+             elem.mozMatchesSelector("html, body, textarea")) ||
> > 
> > Why?
> 
> I assumed it was simply cleanup of an already "out of control" it statement.
> Are you concerned about performance?

Not too much, just wondering.

Comment 9

[Carla Nadastean]

Retested with:
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111212 Firefox/11.0a1 Fennec/11.0a1
HTC Desire Z (Android 2.3)

Bug no longer reproducible. All lists from http://dl.dropbox.com/u/72157/Testing/Select.html can be scrolled properly.
Verifying bug.