Closed
Bug 705145
Opened 14 years ago
Closed 14 years ago
Multiple selection lists cannot be scrolled
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox11 fixed, fennec11+)
VERIFIED
FIXED
People
(Reporter: xti, Assigned: wesj)
Details
Attachments
(1 file, 1 obsolete file)
1.43 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111124
Firefox/11.0a1 Fennec/11.0a1
Devices: Samsung Galaxy Nexus S
OS: Android 2.3.4
Steps to reproduce:
1. Open Fennec App
2. Browse to bugzilla.mozilla.org
3. Tap on Search button > Advance search
4. Scroll down the "Product" multi-selection list
Expected result:
The "Product" list is scrollable.
Actual result:
The "Product" list cannot be scrolled. There will be the same results for any other multi-selection list.
Updated•14 years ago
|
Assignee: nobody → wjohnston
Updated•14 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•14 years ago
|
||
Add these to the list of scrollable things.
Attachment #580388 -
Flags: review?(mark.finkle)
Comment 2•14 years ago
|
||
Comment on attachment 580388 [details] [diff] [review]
Patch
I know this bug is about multiple select listboxes (<select size='1' multiple='1'/>), but should this really be about _any_ listbox (<select size='1'/>) ?
Assignee | ||
Comment 3•14 years ago
|
||
Oh good catch. This scrolls multiple selects and selects with size > 1. Test page:
http://dl.dropbox.com/u/72157/Testing/Select.html
Attachment #580388 -
Attachment is obsolete: true
Attachment #580388 -
Flags: review?(mark.finkle)
Attachment #580409 -
Flags: review?(mark.finkle)
Updated•14 years ago
|
Attachment #580409 -
Flags: review?(mark.finkle) → review+
Comment 4•14 years ago
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 6•14 years ago
|
||
Comment on attachment 580409 [details] [diff] [review]
Patch
>--- a/mobile/android/chrome/content/browser.js
>+++ b/mobile/android/chrome/content/browser.js
>- elem.localName == 'textarea' ||
>- elem.localName == 'html' ||
>- elem.localName == 'body')) {
>+ elem.mozMatchesSelector("html, body, textarea")) ||
Why?
Comment 7•14 years ago
|
||
(In reply to Ms2ger from comment #6)
> Comment on attachment 580409 [details] [diff] [review]
> Patch
>
> >--- a/mobile/android/chrome/content/browser.js
> >+++ b/mobile/android/chrome/content/browser.js
> >- elem.localName == 'textarea' ||
> >- elem.localName == 'html' ||
> >- elem.localName == 'body')) {
> >+ elem.mozMatchesSelector("html, body, textarea")) ||
>
> Why?
I assumed it was simply cleanup of an already "out of control" it statement. Are you concerned about performance?
Comment 8•14 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #7)
> (In reply to Ms2ger from comment #6)
> > Comment on attachment 580409 [details] [diff] [review]
> > Patch
> >
> > >--- a/mobile/android/chrome/content/browser.js
> > >+++ b/mobile/android/chrome/content/browser.js
> > >- elem.localName == 'textarea' ||
> > >- elem.localName == 'html' ||
> > >- elem.localName == 'body')) {
> > >+ elem.mozMatchesSelector("html, body, textarea")) ||
> >
> > Why?
>
> I assumed it was simply cleanup of an already "out of control" it statement.
> Are you concerned about performance?
Not too much, just wondering.
Comment 9•14 years ago
|
||
Retested with:
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111212 Firefox/11.0a1 Fennec/11.0a1
HTC Desire Z (Android 2.3)
Bug no longer reproducible. All lists from http://dl.dropbox.com/u/72157/Testing/Select.html can be scrolled properly.
Verifying bug.
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
tracking-fennec: --- → 11+
Updated•14 years ago
|
status-firefox11:
--- → fixed
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•