70517 - Renamed/Deleted IMAP non-ASCII folders show up as utf-7 strings

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P2)

Description

[ji]

******Observed with win32 02/26 mtrunk build********

The deleted non-ASCII folder name is displayed as a utf-7 string in the Trash
until browser is restarted.

Steps to reproduce:
1. Have a non-ASCII folder in your IMAP account, like "fôlder".
2. Delete the folder.
3. Go to Trash, you'll see the deleted folder shows up as a utf-7 string.
4. Restart the browser, the folder in the Trash goes back to its correct name.

Comment 1

[ji]

Folder rename has this problem as well.
To see it:
Highlight a non-ASCII folder, select File | Rename Folder

Changed the summary accordingly.

Comment 2

[marina]

have to mention that this is a regression, there were several bugs filed on this
and they all are marked verified.

Comment 3

[ji]

Added intl and regression keywords.

Comment 4

[nhottanscp]

Reassign to [e-mail].
Is this related to bug 67859?

Comment 5

[(not reading, please use [e-mail] instead)]

no, I doubt this is related to that subscribe bug.

re-assign to naving.

Comment 6

[(not reading, please use [e-mail] instead)]

this doesn't have to do with that subscribe bug.

I bet local folders will have the same problem if the folder's pretty name 
isn't == the name on disk

my guess is we aren't creating a folder cache element for the new folder (after 
the rename.)  or if we are, we aren't copying over the "onlineName" from the 
old folder cache element.

cc'ing cavin, this is something he's got a bug on for local folders.

Comment 7

[Navin Gupta]

Attachment: proposed fix

Comment 8

[Navin Gupta]

So the fix is basically to convert UTF7Name to PRUnichar and SetName for
that folder. cc bienvenu for review. 

Comment 9

[David :Bienvenu]

instead of passing the server around, you can just call
CreateUnicodeStringFromUtf7 which is defined in nsMsgUtf7Utils.h and is what the
imap server routine calls anyway.

Comment 10

[Navin Gupta]

Attachment: revised patch

Comment 11

[Navin Gupta]

presuming r/sr, david ?

Comment 12

[David :Bienvenu]

sr=bienvenu for revised patch.

Comment 13

[Navin Gupta]

r=sspitzer

Comment 14

[Navin Gupta]

fix landed on trunk

Comment 15

[ji]

Verified with win32, linux and mac 07/06 trunk builds. It's fixed on the trunk.

Comment 16

[msanz]

Navin, can you mark it nsbranch+ now? Adding Scott as well

Comment 17

[scottputterman]

adding the nsbranch+, but I guess I should ask first if there's any chance it
will break renaming ascii folders or creating folders?

Comment 18

[Navin Gupta]

It will not affect Create new folders. It should not break renaming/deleting 
of folders that have ascii names. 

Comment 19

[ji]

Tested renaming/deleting ascii folders. I didn't see any regressions there.
Renaming using a name containing "/" or "\" causes browser hung, but it happens 
before the fix. It's not a regression.

Comment 20

[ji]

The hanging problem when renaming with a folder name containing slash and back 
slash is reported in bug 89698. Again, this problem is NOT caused by this fix.

Comment 21

[scottputterman]

removing the nsbranch.  Montse, if you can get PDT to give us a + for this then
we can get this in.  My guess (though I've been proven wrong) is that this bug
isn't going to make their criteria this late.

Comment 22

[msanz]

I agree, it's not worth the "trip" to PDT, I think I know the answer without
asking. Thanks for fixing it, though, the trunk will be happier.

Comment 23

[Navin Gupta]

fixed on trunk 

Comment 24

[Navin Gupta]

*** Bug 91216 has been marked as a duplicate of this bug. ***

Comment 25

[ji]

Marked it as verified. It's fixed.