The default bug view has changed. See this FAQ.

IonMonkey: getgname does not need a shape guard with TI

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Since our shape guards are kind of broken now (on purpose, waiting for ObjShrink), we need this to run (a modified version of) bitwise-and.
(Assignee)

Comment 1

5 years ago
Created attachment 576895 [details] [diff] [review]
Patch

We can probably get rid of some TypeOracle methods. I'll get to it after getelem/setelem lands to avoid updating the patch David is reviewing.
Attachment #576895 - Flags: review?(dvander)
Attachment #576895 - Flags: review?(bhackett1024)
(Assignee)

Comment 2

5 years ago
Created attachment 576897 [details] [diff] [review]
Patch

Clarify the abort message a bit. According to the isOwnProperty comment we don't abort for properties that are non-writable etc on creation.
Attachment #576895 - Attachment is obsolete: true
Attachment #576895 - Flags: review?(dvander)
Attachment #576895 - Flags: review?(bhackett1024)
Attachment #576897 - Flags: review?(dvander)
Attachment #576897 - Flags: review?(bhackett1024)
Attachment #576897 - Flags: review?(bhackett1024) → review+
Attachment #576897 - Flags: review?(dvander) → review+
(Assignee)

Comment 3

5 years ago
Pushed:

http://hg.mozilla.org/projects/ionmonkey/rev/7100a5b53a31
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.