The default bug view has changed. See this FAQ.

Split style inspector CSS between content & document CSS

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Inspector
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: miker, Assigned: miker)

Tracking

unspecified
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [computedview][ruleview])

Attachments

(1 attachment, 4 obsolete attachments)

We should split style inspector CSS between content & document CSS
Bug triage, filter on PEGASUS.
Whiteboard: [styleinspector] → [computedview][ruleview]
Priority: -- → P2
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Created attachment 604002 [details] [diff] [review]
Patch
Attachment #604002 - Flags: review?(paul)
Blocks: 703643
Comment on attachment 604002 [details] [diff] [review]
Patch

>--- a/browser/devtools/styleinspector/styleinspector.css
>+++ b/browser/devtools/styleinspector/styleinspector.css

>+:root {
>+  -moz-appearance: none;

>+.expander {
>+  -moz-appearance: treetwisty;

>+.expander[open] {
>+  -moz-appearance: treetwistyopen;

>+#propertyContainer {
>+  border-collapse: collapse;

This looks like styling rather than content CSS.
Attachment #604002 - Flags: review?(paul) → review-
No longer blocks: 703643
Created attachment 604068 [details] [diff] [review]
Now depends on bug 703643
Attachment #604002 - Attachment is obsolete: true
Attachment #604068 - Flags: review?(paul)
Depends on: 703643
Comment on attachment 604068 [details] [diff] [review]
Now depends on bug 703643

see comment 3...
Attachment #604068 - Flags: review?(paul) → review-
Created attachment 604084 [details] [diff] [review]
Addressed reviewers comments
Attachment #604068 - Attachment is obsolete: true
Attachment #604084 - Flags: review?(dao)

Comment 7

5 years ago
Comment on attachment 604084 [details] [diff] [review]
Addressed reviewers comments

You forgot to remove #propertyContainer from the theme code.
There's still some "display" properties for the rule-view related code.
Attachment #604084 - Flags: review?(dao) → review-
Created attachment 604386 [details] [diff] [review]
Patch

Fixed
Attachment #604084 - Attachment is obsolete: true
Attachment #604386 - Flags: review?(paul)

Comment 9

5 years ago
Comment on attachment 604386 [details] [diff] [review]
Patch

Review of attachment 604386 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/styleinspector/styleinspector.css
@@ +48,5 @@
> +}
> +
> +.property-name {
> +  display: inline-block;
> +}

add an empty line here.

@@ +92,5 @@
> +}
> +
> +.ruleview-propertyname {
> +  display: inline-block;
> +}

Group the `display:inline-block` related rules together.
Attachment #604386 - Flags: review?(paul) → review+
Created attachment 604787 [details] [diff] [review]
A little optimisation

Done
Attachment #604386 - Attachment is obsolete: true
Whiteboard: [computedview][ruleview] → [computedview][ruleview][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/6dea789aeb4b
Whiteboard: [computedview][ruleview][land-in-fx-team] → [computedview][ruleview][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/6dea789aeb4b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [computedview][ruleview][fixed-in-fx-team] → [computedview][ruleview]
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.