Closed
Bug 705276
Opened 13 years ago
Closed 12 years ago
Split style inspector CSS between content & document CSS
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: miker, Assigned: miker)
References
Details
(Whiteboard: [computedview][ruleview])
Attachments
(1 file, 4 obsolete files)
12.64 KB,
patch
|
Details | Diff | Splinter Review |
We should split style inspector CSS between content & document CSS
Assignee | ||
Comment 1•12 years ago
|
||
Bug triage, filter on PEGASUS.
Whiteboard: [styleinspector] → [computedview][ruleview]
Assignee | ||
Updated•12 years ago
|
Priority: -- → P2
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #604002 -
Flags: review?(paul)
Comment 3•12 years ago
|
||
Comment on attachment 604002 [details] [diff] [review] Patch >--- a/browser/devtools/styleinspector/styleinspector.css >+++ b/browser/devtools/styleinspector/styleinspector.css >+:root { >+ -moz-appearance: none; >+.expander { >+ -moz-appearance: treetwisty; >+.expander[open] { >+ -moz-appearance: treetwistyopen; >+#propertyContainer { >+ border-collapse: collapse; This looks like styling rather than content CSS.
Attachment #604002 -
Flags: review?(paul) → review-
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #604002 -
Attachment is obsolete: true
Attachment #604068 -
Flags: review?(paul)
Comment 5•12 years ago
|
||
Comment on attachment 604068 [details] [diff] [review] Now depends on bug 703643 see comment 3...
Attachment #604068 -
Flags: review?(paul) → review-
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #604068 -
Attachment is obsolete: true
Attachment #604084 -
Flags: review?(dao)
Comment 7•12 years ago
|
||
Comment on attachment 604084 [details] [diff] [review] Addressed reviewers comments You forgot to remove #propertyContainer from the theme code. There's still some "display" properties for the rule-view related code.
Attachment #604084 -
Flags: review?(dao) → review-
Assignee | ||
Comment 8•12 years ago
|
||
Fixed
Attachment #604084 -
Attachment is obsolete: true
Attachment #604386 -
Flags: review?(paul)
Comment 9•12 years ago
|
||
Comment on attachment 604386 [details] [diff] [review] Patch Review of attachment 604386 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/styleinspector/styleinspector.css @@ +48,5 @@ > +} > + > +.property-name { > + display: inline-block; > +} add an empty line here. @@ +92,5 @@ > +} > + > +.ruleview-propertyname { > + display: inline-block; > +} Group the `display:inline-block` related rules together.
Attachment #604386 -
Flags: review?(paul) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [computedview][ruleview] → [computedview][ruleview][land-in-fx-team]
Comment 11•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6dea789aeb4b
Whiteboard: [computedview][ruleview][land-in-fx-team] → [computedview][ruleview][fixed-in-fx-team]
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6dea789aeb4b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [computedview][ruleview][fixed-in-fx-team] → [computedview][ruleview]
Target Milestone: --- → Firefox 13
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•