705276 - Split style inspector CSS between content & document CSS

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We should split style inspector CSS between content & document CSS

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Bug triage, filter on PEGASUS.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 604002 [details] [diff] [review]
Patch

>--- a/browser/devtools/styleinspector/styleinspector.css
>+++ b/browser/devtools/styleinspector/styleinspector.css

>+:root {
>+  -moz-appearance: none;

>+.expander {
>+  -moz-appearance: treetwisty;

>+.expander[open] {
>+  -moz-appearance: treetwistyopen;

>+#propertyContainer {
>+  border-collapse: collapse;

This looks like styling rather than content CSS.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Now depends on bug 703643

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 604068 [details] [diff] [review]
Now depends on bug 703643

see comment 3...

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Addressed reviewers comments

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 604084 [details] [diff] [review]
Addressed reviewers comments

You forgot to remove #propertyContainer from the theme code.
There's still some "display" properties for the rule-view related code.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

Fixed

Comment 9

[Paul Rouget [:paul]]

Comment on attachment 604386 [details] [diff] [review]
Patch

Review of attachment 604386 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/styleinspector/styleinspector.css
@@ +48,5 @@
> +}
> +
> +.property-name {
> +  display: inline-block;
> +}

add an empty line here.

@@ +92,5 @@
> +}
> +
> +.ruleview-propertyname {
> +  display: inline-block;
> +}

Group the `display:inline-block` related rules together.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: A little optimisation

Done

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/6dea789aeb4b

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/6dea789aeb4b