Remove JSOPTION_JIT and JSOPTION_PROFILING

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
mozilla11
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
JSOPTION_JIT is unused now that TM has been removed. References to it should be removed.
(Assignee)

Comment 1

6 years ago
Created attachment 576995 [details] [diff] [review]
Patch

dvander, can you review this?

Also, I'm wondering if some of these removals should have JSOPTION_METHODJIT and/or JSOPTION_TYPE_INFERENCE set instead of outright removal. Comments?
Assignee: general → ryanvm
Attachment #576995 - Flags: review?(dvander)
(Assignee)

Comment 2

6 years ago
JSOPTION_PROFILING should probably go too, now that I think about it.
(Assignee)

Updated

6 years ago
Summary: Remove JSOPTION_JIT → Remove JSOPTION_JIT and JSOPTION_PROFILING

Comment 3

6 years ago
Try run for c0b6fe6eb324 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c0b6fe6eb324
Results (out of 13 total builds):
    exception: 7
    failure: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ryanvm@gmail.com-c0b6fe6eb324
(Assignee)

Comment 4

6 years ago
Created attachment 577006 [details] [diff] [review]
Remove JSOPTION_JIT and JSOPTION_PROFILING

This patch also removes the profiling prefs. Try results incoming.
Attachment #576995 - Attachment is obsolete: true
Attachment #576995 - Flags: review?(dvander)
Attachment #577006 - Flags: review?(dvander)
Attachment #577006 - Flags: review?(dvander) → review+
(Assignee)

Comment 5

6 years ago
David, this apparently blew up xpcshell tests. I can't figure out why, though.
https://tbpl.mozilla.org/?tree=Try&rev=24e506407c7f

Comment 6

6 years ago
Try run for 24e506407c7f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=24e506407c7f
Results (out of 190 total builds):
    exception: 1
    success: 142
    warnings: 41
    failure: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ryanvm@gmail.com-24e506407c7f
(Assignee)

Comment 7

6 years ago
Of course! It was probably dying because xpcshell was being invoked with -j still. Pretty funny since I had posted a patch to bug 604216 just prior to filing this one to change that to -m -n. Trying this push again with both patches this time.
Depends on: 604216

Comment 8

6 years ago
Try run for d7cd75718272 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d7cd75718272
Results (out of 189 total builds):
    exception: 1
    success: 164
    warnings: 19
    failure: 5
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ryanvm@gmail.com-d7cd75718272
(Assignee)

Comment 9

6 years ago
xpcshell tests are all green now!
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [needs 604216 to be checked in with it]
(note that bug 604216 landed on m-i earlier today)

Landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d984d11bffea
Keywords: checkin-needed
Whiteboard: [needs 604216 to be checked in with it]
Target Milestone: --- → mozilla11
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/d984d11bffea
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.