Closed
Bug 705414
Opened 14 years ago
Closed 14 years ago
Check JS_DefineElement for failure in nsScriptableRegion::GetRects
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: drexler)
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
evilpies
:
review+
Ms2ger
:
feedback+
|
Details | Diff | Splinter Review |
JS_DefineElement can fail, and we shouldn't continue after it's returned false.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #578876 -
Flags: feedback?(Ms2ger)
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 578876 [details] [diff] [review]
patch v1
Looks good to me; Tom, could you review?
Attachment #578876 -
Flags: review?(evilpies)
Attachment #578876 -
Flags: feedback?(Ms2ger)
Attachment #578876 -
Flags: feedback+
|
||
Comment 3•14 years ago
|
||
Comment on attachment 578876 [details] [diff] [review]
patch v1
Looks good, Thank you.
Attachment #578876 -
Flags: review?(evilpies) → review+
|
|
Reporter | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Updated•14 years ago
|
Assignee: nobody → andrew.quartey
|
|
||
Comment 4•14 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla11
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 6•14 years ago
|
||
Removing from the good first bug list
Whiteboard: [good first bug][mentor=Ms2ger]
|
|
Reporter | |
Comment 7•14 years ago
|
||
Why? Is anybody trying to suggest that people fix closed bugs?
You need to log in
before you can comment on or make changes to this bug.
Description
•