Check JS_DefineElement for failure in nsScriptableRegion::GetRects

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: drexler)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
JS_DefineElement can fail, and we shouldn't continue after it's returned false.
(Assignee)

Comment 1

6 years ago
Created attachment 578876 [details] [diff] [review]
patch v1
Attachment #578876 - Flags: feedback?(Ms2ger)
(Reporter)

Comment 2

6 years ago
Comment on attachment 578876 [details] [diff] [review]
patch v1

Looks good to me; Tom, could you review?
Attachment #578876 - Flags: review?(evilpies)
Attachment #578876 - Flags: feedback?(Ms2ger)
Attachment #578876 - Flags: feedback+
Comment on attachment 578876 [details] [diff] [review]
patch v1

Looks good, Thank you.
Attachment #578876 - Flags: review?(evilpies) → review+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Assignee: nobody → andrew.quartey
http://hg.mozilla.org/integration/mozilla-inbound/rev/4a1a8b361f59
Keywords: checkin-needed
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/4a1a8b361f59
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Removing from the good first bug list
Whiteboard: [good first bug][mentor=Ms2ger]
(Reporter)

Comment 7

6 years ago
Why? Is anybody trying to suggest that people fix closed bugs?
You need to log in before you can comment on or make changes to this bug.