705451 - html anchors do not always update in url bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

1. Load http://people.mozilla.com/~nhirata/html_tp/jumptag.html
2. Click on the "Go to bottom" link (ignore the fact that this may not actually scroll to the bottom - that's bug 704690)
3. Observe how the URL displayed in the url bar now has #bottom appended to it
4. Go to the bottom of the page and click on the "Go to top" link (again, ignore that this may not actually scroll)

Expected behaviour: the URL displayed in the URL bar should have #top instead of #bottom appended to it.
Observed behaviour: the URL displayed still has #bottom displayed.

Note also that if you tap on the URL bar at this point to edit the URL, the editable URL field shows #top (as is expected) but canceling the edit and returning to the page view again shows #bottom.

Comment 1

[John Hammink]

I can reproduce this on my Samsung Galaxy tab 3.1 with latestly nightly fennec native (11.28)

Comment 2

[Sriram Ramasubramanian [:sriram]]

I tried it today, and it seems to work fine for me. Please reopen if you still find this bug.

I/GeckoApp(10338): Got message: Content:LocationChange
I/GeckoApp(10338): URI - http://people.mozilla.com/~nhirata/html_tp/jumptag.html#top
I/GeckoTab(10338): Updated url: http://people.mozilla.com/~nhirata/html_tp/jumptag.html#top for tab with id: 2

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I'm still seeing this, but now the URL bar never updates. Reopening after discussing with Sriram on IRC - the expected behaviour is that the URL bar should always update and show the correct #target.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The anchors are updated in the url bar. Earlier we were returning, if it was just a "#" change. Now the url bar alone is updated.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6edca769b33a

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/6edca769b33a

Comment 7

[Aaron Train [:aaronmt]]

Samsung Galaxy SII (Android 2.3.4)
20111208060054
http://hg.mozilla.org/integration/mozilla-inbound/rev/b0f8871174a5