705457 - Tab key should move focus to the next field in a form

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Dustin]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.2 (KHTML, like Gecko) Chrome/15.0.874.121 Safari/535.2

Steps to reproduce:

Went to Amazon.com or Hotmail.com clicked on a field and hit the tab key on my Asus transformer dock.  Tried up/down/left/right, no response at all.


Actual results:

It appears Firefox inserted a literal "Tab" into the entry field.


Expected results:

It should have tabbed from the user name to the password field.

Comment 1

[Alex Pakhotin (:alexp)]

Changing the summary to describe the actual issue.
Arrow keys work inside the edit boxes, or switch between the options as they should. They are not supposed to move between the fields.
The issue is reproducible both on HKB's and VKB's with a Tab key (e.g. Hacker's Keyboard).

Comment 2

[Alex Pakhotin (:alexp)]

It's a regression - it worked before the pan/zoom layers were added.
Looks like our LayerView, which extends GLSurfaceView, does not get key-down events, its onKeyDown method (and the same one in GeckoInputConnection) does not get called, and that causes this issue.

Comment 3

[Alex Pakhotin (:alexp)]

Attachment: Fix

This seems to fix the bug. The onKeyPreIme() still gets called, and an explicit check for the Tab key there works.

Comment 4

[Alex Pakhotin (:alexp)]

hg.mozilla.org/projects/birch/rev/5f197183f884

Comment 5

[Carla Nadastean]

Retested bug with :
Mozilla/5.0 (Android; Linux arm7l; rv:11.0a1) Gecko/20111205 Firefox/11.0a1 Fennec/11.0a1

Focus is changed from a field to next field when tab key is used. (For Hotmail and Gmail pages, from username to password field.)

Verifying bug.