Last Comment Bug 705464 - typo in gcli.properties
: typo in gcli.properties
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 11
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
: J. Ryan Stinnett [:jryans] (use ni?)
Mentors:
Depends on:
Blocks: GCLI-SHIP
  Show dependency treegraph
 
Reported: 2011-11-26 10:44 PST by Mark Tyndall
Modified: 2011-12-08 21:30 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
upload 1 (1.21 KB, patch)
2011-12-02 02:50 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
dcamp: review+
Details | Diff | Splinter Review

Description Mark Tyndall 2011-11-26 10:44:30 PST
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/gcli.properties#70

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/gcli.properties#75

typesNumberMax=%1$S is smaller that minimum allowed: %2$S.
typesNumberMin=%1$S is smaller that minimum allowed: %2$S.

In both cases, "that" should be "than".

This is also on aurora (where I saw it, whilst localising).  You can fix this there without affecting the string freeze.
Comment 1 Mark Tyndall 2011-11-26 10:49:45 PST
(sorry for the bugspam, I forgot this was so closely related to the file above.)

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/webconsole.properties#94

helperFuncUnsupportedTypeError=Can't call pprint on this type of object.

Is "pprint" some arcane function, or (as I suspect) a typo?
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-01 14:22:02 PST
(In reply to Mark Tyndall from comment #1)
> Is "pprint" some arcane function, or (as I suspect) a typo?

It's only slightly arcane - the console has functions [1] to do pretty printing, and we borrow the name pprint for this from 'python' [2].

[1] https://developer.mozilla.org/en/Using_the_Web_Console/Helpers
[2] http://docs.python.org/library/pprint.html
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-02 02:50:38 PST
Created attachment 578534 [details] [diff] [review]
upload 1

a.k.a https://github.com/campd/gcli/pull/8
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-05 03:57:00 PST
https://tbpl.mozilla.org/?tree=Try&rev=2444a569f2c7
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-08 06:06:05 PST
https://tbpl.mozilla.org/?tree=Fx-Team&rev=cf3ed4316481
Comment 6 Tim Taubert [:ttaubert] 2011-12-08 21:30:05 PST
https://hg.mozilla.org/mozilla-central/rev/b692f4f2a0cf

Note You need to log in before you can comment on or make changes to this bug.