Last Comment Bug 705473 - typos in
: typos in
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: 9 Branch
: All All
-- normal (vote)
: mozilla11
Assigned To: Henri Sivonen (:hsivonen)
: Andrew Overholt [:overholt]
Depends on:
Blocks: 482921
  Show dependency treegraph
Reported: 2011-11-26 13:02 PST by Mark Tyndall
Modified: 2011-12-14 01:06 PST (History)
2 users (show)
hsivonen: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix the typos (2.80 KB, patch)
2011-11-28 05:05 PST, Henri Sivonen (:hsivonen)
bugs: review+
christian: approval‑mozilla‑aurora-
Details | Diff | Splinter Review

Description User image Mark Tyndall 2011-11-26 13:02:50 PST

errSlashNotFollowedByGt=A slash was not immediate followed by “>”.
"immediate" should be "immediately"

errUnquotedAttributeStartLt should end with a "." (all the other strings do).

This is also on aurora (where I saw it, whilst localising).  You can fix this there without affecting the string freeze.
Comment 1 User image Henri Sivonen (:hsivonen) 2011-11-28 05:05:57 PST
Created attachment 577225 [details] [diff] [review]
Fix the typos
Comment 2 User image Henri Sivonen (:hsivonen) 2011-11-28 22:58:21 PST
Comment 3 User image Marco Bonardo [::mak] 2011-11-29 05:05:10 PST
Comment 4 User image Henri Sivonen (:hsivonen) 2011-12-13 05:08:50 PST
Comment on attachment 577225 [details] [diff] [review]
Fix the typos

(This comment has been posted on all the bugs mentioned in this comment, except bug 710142, so that the release drivers see it regardless of the order in which they process approval requests.)

The new View Source implementation landed before Firefox 10 moved to Aurora. Afterwards, a bunch of regressions were identified. Many of the regression fixes didn't land before Firefox 10 moved to Aurora but they have now been fixed on trunk except for bug 710142.

To avoid shipping with regressions, we either need to land all the regression fixes on Aurora for Firefox 10 (followed by a fix for bug 710142 in Beta if it doesn't make it before Dec 20th) or switch back to the old View Source implementation on Aurora. The new View Source implementation provides much better diagnostics for Web developers than the old View Source implementation.

So I'd like to ask the release drivers to either approve bug 535530, bug 699356, bug 699365, bug 700034, bug 700361, bug 703965, bug 704667 and bug 705473 plus bug 695640, which is a non-regression tweak, or to approve bug 710175 for reverting to the old View Source implementation for Firefox 10.
Comment 5 User image christian 2011-12-13 14:43:15 PST
Comment on attachment 577225 [details] [diff] [review]
Fix the typos

[triage comment]
We decided to back out the new view source parser (bug 710175) rather than take this fixup for Firefox 10.

Denying for Aurora.
Comment 6 User image Henri Sivonen (:hsivonen) 2011-12-14 01:06:00 PST
Firefox 10 no longer affected due to bug 710175 landing. (Not affected in the sense that the UI string newer shows up even though the property file is there.)

Note You need to log in before you can comment on or make changes to this bug.