705602 - Use mallocSizeOf in prefixset memory reporter

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: patch

I'm converting existing memory reporters to use mallocSizeOf.  See https://wiki.mozilla.org/Memory_Reporting for details about why I'm doing this.

This patch changes the "prefixset" memory reporter accordingly.  As part of this change, I removed nsUrlClassifierPrefixSet::SizeOfIncludingThis from the IDL, because there's no need for SizeOf-style functions to be exposed via IDL;  no other such functions are exposed in this way.  That change simplifies it significantly.

Comment 1

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Gian-Carlo, can you do this review soon?  It's a very small patch and it's blocking several pieces of my memory reporter work.  Thanks!

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 577193 [details] [diff] [review]
patch

You changed the UUID without updating everything. You'll need to update toolkit/components/build/nsToolkitCompsCID.h as well or things are going to break.

r+ if that is fixed.

Comment 3

[Nicholas Nethercote [:njn] (On Long Service Leave)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03af7a7c3dc3

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/03af7a7c3dc3