Use mallocSizeOf in prefixset memory reporter

RESOLVED FIXED in Firefox 11

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 577193 [details] [diff] [review]
patch

I'm converting existing memory reporters to use mallocSizeOf.  See https://wiki.mozilla.org/Memory_Reporting for details about why I'm doing this.

This patch changes the "prefixset" memory reporter accordingly.  As part of this change, I removed nsUrlClassifierPrefixSet::SizeOfIncludingThis from the IDL, because there's no need for SizeOf-style functions to be exposed via IDL;  no other such functions are exposed in this way.  That change simplifies it significantly.
Attachment #577193 - Flags: review?(gpascutto)
(Assignee)

Updated

6 years ago
Whiteboard: [MemShrink] → [MemShrink:P2]
(Assignee)

Updated

6 years ago
Blocks: 707865
(Assignee)

Comment 1

6 years ago
Gian-Carlo, can you do this review soon?  It's a very small patch and it's blocking several pieces of my memory reporter work.  Thanks!
Comment on attachment 577193 [details] [diff] [review]
patch

You changed the UUID without updating everything. You'll need to update toolkit/components/build/nsToolkitCompsCID.h as well or things are going to break.

r+ if that is fixed.
Attachment #577193 - Flags: review?(gpascutto) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/03af7a7c3dc3
https://hg.mozilla.org/mozilla-central/rev/03af7a7c3dc3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.