Closed
Bug 705602
Opened 14 years ago
Closed 14 years ago
Use mallocSizeOf in prefixset memory reporter
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: [MemShrink:P2])
Attachments
(1 file)
|
4.26 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
I'm converting existing memory reporters to use mallocSizeOf. See https://wiki.mozilla.org/Memory_Reporting for details about why I'm doing this.
This patch changes the "prefixset" memory reporter accordingly. As part of this change, I removed nsUrlClassifierPrefixSet::SizeOfIncludingThis from the IDL, because there's no need for SizeOf-style functions to be exposed via IDL; no other such functions are exposed in this way. That change simplifies it significantly.
Attachment #577193 -
Flags: review?(gpascutto)
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
|
|
Assignee | |
Comment 1•14 years ago
|
||
Gian-Carlo, can you do this review soon? It's a very small patch and it's blocking several pieces of my memory reporter work. Thanks!
|
||
Comment 2•14 years ago
|
||
Comment on attachment 577193 [details] [diff] [review]
patch
You changed the UUID without updating everything. You'll need to update toolkit/components/build/nsToolkitCompsCID.h as well or things are going to break.
r+ if that is fixed.
Attachment #577193 -
Flags: review?(gpascutto) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•