Closed Bug 705654 Opened 10 years ago Closed 10 years ago

Fix uses of uninitialized memory found by valgrind in 632423-1.html

Categories

(Core :: Plug-ins, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file)

No description provided.
Attachment #577244 - Flags: review?(joshmoz)
Comment on attachment 577244 [details] [diff] [review]
Fix uses of uninitialized memory found by valgrind in 632423-1.html

Review of attachment 577244 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginMessageUtils.cpp
@@ +80,5 @@
>  namespace mozilla {
>  namespace plugins {
>  
> +NPRemoteWindow::NPRemoteWindow() :
> +  window(0), x(0), y(0), width(0), height(0), type(NPWindowTypeWindow)

Make the default type "NPWindowTypeDrawable". Doesn't matter much, but conceptually drawable is a better "default" as we prefer it over windowed.
Attachment #577244 - Flags: review?(joshmoz) → review+
Attachment #577244 - Flags: review?(ehsan)
https://hg.mozilla.org/mozilla-central/rev/c3b13c7ff1cb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.