705654 - Fix uses of uninitialized memory found by valgrind in 632423-1.html

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Fix uses of uninitialized memory found by valgrind in 632423-1.html

https://tbpl.mozilla.org/?tree=Try&rev=34530b1f60cc

Comment 2

[Josh Aas]

Comment on attachment 577244 [details] [diff] [review]
Fix uses of uninitialized memory found by valgrind in 632423-1.html

Review of attachment 577244 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginMessageUtils.cpp
@@ +80,5 @@
>  namespace mozilla {
>  namespace plugins {
>  
> +NPRemoteWindow::NPRemoteWindow() :
> +  window(0), x(0), y(0), width(0), height(0), type(NPWindowTypeWindow)

Make the default type "NPWindowTypeDrawable". Doesn't matter much, but conceptually drawable is a better "default" as we prefer it over windowed.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c3b13c7ff1cb

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/c3b13c7ff1cb