Last Comment Bug 705654 - Fix uses of uninitialized memory found by valgrind in 632423-1.html
: Fix uses of uninitialized memory found by valgrind in 632423-1.html
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla11
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-28 06:37 PST by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-11-29 04:51 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix uses of uninitialized memory found by valgrind in 632423-1.html (2.45 KB, patch)
2011-11-28 06:40 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
jaas: review+
Details | Diff | Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-28 06:37:12 PST

    
Comment 1 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-28 06:40:54 PST
Created attachment 577244 [details] [diff] [review]
Fix uses of uninitialized memory found by valgrind in 632423-1.html

https://tbpl.mozilla.org/?tree=Try&rev=34530b1f60cc
Comment 2 Josh Aas 2011-11-28 07:57:45 PST
Comment on attachment 577244 [details] [diff] [review]
Fix uses of uninitialized memory found by valgrind in 632423-1.html

Review of attachment 577244 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginMessageUtils.cpp
@@ +80,5 @@
>  namespace mozilla {
>  namespace plugins {
>  
> +NPRemoteWindow::NPRemoteWindow() :
> +  window(0), x(0), y(0), width(0), height(0), type(NPWindowTypeWindow)

Make the default type "NPWindowTypeDrawable". Doesn't matter much, but conceptually drawable is a better "default" as we prefer it over windowed.
Comment 3 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-11-28 08:20:48 PST
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c3b13c7ff1cb
Comment 4 Marco Bonardo [::mak] 2011-11-29 04:51:40 PST
https://hg.mozilla.org/mozilla-central/rev/c3b13c7ff1cb

Note You need to log in before you can comment on or make changes to this bug.