The default bug view has changed. See this FAQ.

Fix uses of uninitialized memory found by valgrind in 632423-1.html

RESOLVED FIXED in mozilla11

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla11
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 577244 [details] [diff] [review]
Fix uses of uninitialized memory found by valgrind in 632423-1.html

https://tbpl.mozilla.org/?tree=Try&rev=34530b1f60cc
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #577244 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #577244 - Flags: review?(joshmoz)

Comment 2

5 years ago
Comment on attachment 577244 [details] [diff] [review]
Fix uses of uninitialized memory found by valgrind in 632423-1.html

Review of attachment 577244 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginMessageUtils.cpp
@@ +80,5 @@
>  namespace mozilla {
>  namespace plugins {
>  
> +NPRemoteWindow::NPRemoteWindow() :
> +  window(0), x(0), y(0), width(0), height(0), type(NPWindowTypeWindow)

Make the default type "NPWindowTypeDrawable". Doesn't matter much, but conceptually drawable is a better "default" as we prefer it over windowed.
Attachment #577244 - Flags: review?(joshmoz) → review+

Updated

5 years ago
Attachment #577244 - Flags: review?(ehsan)
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c3b13c7ff1cb
https://hg.mozilla.org/mozilla-central/rev/c3b13c7ff1cb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.