The default bug view has changed. See this FAQ.

Broken SKIA compilation on mingw

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

fix
7.13 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 577246 [details] [diff] [review]
fix

I'm attaching a patch that fixes the compilation for me. Fixes to SKIA parts are submitted to upstream for review: http://codereview.appspot.com/5444044/ Mozilla-specific changes include passing -msse2 flags to compilations of files using SSE2.
(Assignee)

Comment 1

5 years ago
Created attachment 577548 [details] [diff] [review]
fix

The patch has been accepted to upstream. The attached patch adds it to Mozilla version until.
Assignee: nobody → jacek
Attachment #577246 - Attachment is obsolete: true
Attachment #577548 - Flags: review?(matt.woodrow)
Attachment #577548 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 2

5 years ago
Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b4c709c2dfc
Whiteboard: [inbound]
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/mozilla-central/rev/0b4c709c2dfc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.