705943 - [SeaMonkey] mochitest-other: browser_bug92473.js and browser_bug134911.js report "Console message: [JavaScript Error: "SetForcedCharset is not defined"" since changeset 0e6b8ae8eb21

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Serge Gautherie (:sgautherie)]

I assume this started with
http://hg.mozilla.org/mozilla-central/rev/0e6b8ae8eb21
"remove FUEL usage from these tests. a=tests-only"

At first glance, I would guess SetForcedCharset() is defined in Firefox browser.js only :-/
Then these tests should be Firefox specific (as they used to be) or this function should be defined in Core or Toolkit (or ported to SeaMonkey SMILE).

Comment 1

[[e-mail]]

SetForcedCharset just calls BrowserSetForcedCharacterSet, which we do have.

Comment 2

[Simon Montagu :smontagu]

Attachment: Use BrowserSetForcedCharacterSet instead of SetForcedCharset

BrowserSetForcedCharacterSet exists in both Firefox and Seamonkey

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 577710 [details] [diff] [review]
Use BrowserSetForcedCharacterSet instead of SetForcedCharset

This patch should fix the reported errors just fine :-)

Yet, while there, what is the actual use of Firefox SetForcedCharset()?
As in: could it be deprecated/removed, or shouldn't it rather be added to SeaMonkey?

Comment 4

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7ce73fb7a71

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f7ce73fb7a71

Comment 6

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1322765602.1322769171.17358.gz&fulltext=1
OS X 10.6 comm-central-trunk debug test mochitest-other on 2011/12/01 10:53:22

V.Fixed