Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[SeaMonkey] mochitest-other: browser_bug92473.js and browser_bug134911.js report "Console message: [JavaScript Error: "SetForcedCharset is not defined"" since changeset 0e6b8ae8eb21

VERIFIED FIXED in mozilla11

Status

()

Core
Internationalization
--
major
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: smontagu)

Tracking

(Blocks: 1 bug, {regression})

Trunk
mozilla11
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [perma-orange], URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
I assume this started with
http://hg.mozilla.org/mozilla-central/rev/0e6b8ae8eb21
"remove FUEL usage from these tests. a=tests-only"

At first glance, I would guess SetForcedCharset() is defined in Firefox browser.js only :-/
Then these tests should be Firefox specific (as they used to be) or this function should be defined in Core or Toolkit (or ported to SeaMonkey SMILE).

Comment 1

6 years ago
SetForcedCharset just calls BrowserSetForcedCharacterSet, which we do have.
(Assignee)

Comment 2

6 years ago
Created attachment 577710 [details] [diff] [review]
Use BrowserSetForcedCharacterSet instead of SetForcedCharset

BrowserSetForcedCharacterSet exists in both Firefox and Seamonkey
Attachment #577710 - Flags: review?(dao)

Updated

6 years ago
Attachment #577710 - Flags: review?(dao) → review+
(Reporter)

Comment 3

6 years ago
Comment on attachment 577710 [details] [diff] [review]
Use BrowserSetForcedCharacterSet instead of SetForcedCharset

This patch should fix the reported errors just fine :-)

Yet, while there, what is the actual use of Firefox SetForcedCharset()?
As in: could it be deprecated/removed, or shouldn't it rather be added to SeaMonkey?
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7ce73fb7a71
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/f7ce73fb7a71
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Reporter)

Comment 6

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1322765602.1322769171.17358.gz&fulltext=1
OS X 10.6 comm-central-trunk debug test mochitest-other on 2011/12/01 10:53:22

V.Fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.