Closed
Bug 705957
Opened 13 years ago
Closed 13 years ago
test_bug_511615.html: correct the spelling of "privledged"
Categories
(Toolkit :: Form Manager, defect)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: sgautherie, Assigned: sgautherie)
Details
Attachments
(2 files, 1 obsolete file)
|
8.56 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
8.53 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
Bug 641716 patch Av1, with bug 641716 comment 9 and 10 suggestion(s).
Attachment #577445 -
Flags: review?(ehsan)
|
||
Updated•13 years ago
|
Attachment #577445 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 2•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla11
|
||
Comment 3•13 years ago
|
||
Would have been nicer if you'd used "privileged" instead of "priviledged".
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 577445 [details] [diff] [review]
(Av1) test_bug_511615.html: Correct the spelling of "privledged", Add 2 comments
[Checked in: Comment 4]
http://hg.mozilla.org/mozilla-central/rev/f212a34be465
Attachment #577445 -
Attachment description: (Av1) test_bug_511615.html: Correct the spelling of "privledged", Add 2 comments → (Av1) test_bug_511615.html: Correct the spelling of "privledged", Add 2 comments
[Checked in: Comment 4]
|
|
Assignee | |
Comment 5•13 years ago
|
||
Per comment 3, plus 1 nit.
Attachment #578227 -
Flags: review?(ehsan)
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Flags: in-testsuite+
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•13 years ago
|
||
Ehsan, ping for review.
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 578227 [details] [diff] [review]
(Bv1) test_bug_511615.html: Improve the spelling of "priviledged", Remove extra '_' in test file name
Why do you need to rename the test file? That makes things like looking up the test file name in Bugzilla harder than they need to be.
The rest of the patch looks fine, FWIW.
Attachment #578227 -
Flags: review?(ehsan) → review-
|
|
Assignee | |
Comment 9•13 years ago
|
||
Bv1, with comment 8 suggestion(s).
(In reply to Ehsan Akhgari [:ehsan] from comment #8)
> Why do you need to rename the test file?
Only because I noticed very few tests have a '_' there.
Attachment #578227 -
Attachment is obsolete: true
Attachment #583719 -
Flags: review?(ehsan)
|
|
||
Comment 10•13 years ago
|
||
Comment on attachment 583719 [details] [diff] [review]
(Bv2) test_bug_511615.html: Improve the spelling of "priviledged"
[Checked in: Comment 11]
r=me, thanks!
Attachment #583719 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 11•13 years ago
|
||
Comment on attachment 583719 [details] [diff] [review]
(Bv2) test_bug_511615.html: Improve the spelling of "priviledged"
[Checked in: Comment 11]
https://hg.mozilla.org/mozilla-central/rev/8d341b0d8904
Attachment #583719 -
Attachment description: (Bv2) test_bug_511615.html: Improve the spelling of "priviledged" → (Bv2) test_bug_511615.html: Improve the spelling of "priviledged"
[Checked in: Comment 11]
|
|
Assignee | |
Updated•13 years ago
|
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla11 → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•