Move static feature blocks to compiled-in blocklist

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: drs, Assigned: drs)

Tracking

Trunk
mozilla11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Previously, we lived in a world where we didn't have a generalized blocklist which works on all platforms. With the changes in bug 668004, we now have a proper blocklist on every platform, so we can move some of the hacked-in special cases to this blocklist. Note that I'm not at all referring to the downloadable blocklist.
(Assignee)

Updated

6 years ago
Assignee: nobody → dsherk
Depends on: 668004
(Assignee)

Updated

6 years ago
Blocks: 706702
(Assignee)

Comment 1

6 years ago
Created attachment 578496 [details] [diff] [review]
Patch v1.0, move some special cases to static blocklist.

Moves some of the special cases that we wrote into the GfxInfo classes to the statically compiled-in blocklist. This is preferable because it is easier to see what's going on, and is easier to remove (there can be no mistakes in code flow when one of these entries are removed which causes bugs in handling other special cases).
Attachment #578496 - Flags: review?(joe)
(Assignee)

Comment 2

6 years ago
Try push: https://tbpl.mozilla.org/?tree=Try&rev=abe278c327db
Comment on attachment 578496 [details] [diff] [review]
Patch v1.0, move some special cases to static blocklist.

Review of attachment 578496 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the cleanups

::: widget/src/android/GfxInfo.cpp
@@ +309,5 @@
> +     * It is staying here for reference. The best way to do this now is to add
> +     * an entry in the list above. There is a dummy entry which will whitelist a
> +     * device when uncommented and device/vendor IDs are inserted. It is
> +     * preferred that we stop whitelisting and instead go to blocklisting, where
> +     * everything is assumed to be okay as long as it's not in the blocklist. */

I think we should just delete this code altogether. We can always find it in mercurial. :)

::: widget/src/cocoa/GfxInfo.mm
@@ +400,5 @@
>    {
>      status = nsIGfxInfo::FEATURE_BLOCKED_OS_VERSION;
>    }
>  
> +  // The code around the following has been moved into the global blocklist.

Let's just delete the whole block.
Attachment #578496 - Flags: review?(joe) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 579857 [details] [diff] [review]
Patch v1.1, move some special cases to the static blocklist.

Removed comments/old code. +r carried
Attachment #578496 - Attachment is obsolete: true
Attachment #579857 - Flags: review+
(Assignee)

Comment 5

6 years ago
https://tbpl.mozilla.org/?rev=fe937bac6e75
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8f7893e1c20c
Target Milestone: --- → mozilla11
Backed out from beta only:
http://hg.mozilla.org/releases/mozilla-beta/rev/08e1dd305b6b
See bug 711656 for explanation.
You need to log in before you can comment on or make changes to this bug.