Last Comment Bug 705959 - Move static feature blocks to compiled-in blocklist
: Move static feature blocks to compiled-in blocklist
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Doug Sherk (:drs) (inactive)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on: 668004
Blocks: 706702
  Show dependency treegraph
 
Reported: 2011-11-28 17:40 PST by Doug Sherk (:drs) (inactive)
Modified: 2012-03-08 15:13 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1.0, move some special cases to static blocklist. (9.60 KB, patch)
2011-12-01 21:44 PST, Doug Sherk (:drs) (inactive)
joe: review+
Details | Diff | Splinter Review
Patch v1.1, move some special cases to the static blocklist. (10.38 KB, patch)
2011-12-07 15:08 PST, Doug Sherk (:drs) (inactive)
bugzilla: review+
Details | Diff | Splinter Review

Description Doug Sherk (:drs) (inactive) 2011-11-28 17:40:56 PST
Previously, we lived in a world where we didn't have a generalized blocklist which works on all platforms. With the changes in bug 668004, we now have a proper blocklist on every platform, so we can move some of the hacked-in special cases to this blocklist. Note that I'm not at all referring to the downloadable blocklist.
Comment 1 Doug Sherk (:drs) (inactive) 2011-12-01 21:44:14 PST
Created attachment 578496 [details] [diff] [review]
Patch v1.0, move some special cases to static blocklist.

Moves some of the special cases that we wrote into the GfxInfo classes to the statically compiled-in blocklist. This is preferable because it is easier to see what's going on, and is easier to remove (there can be no mistakes in code flow when one of these entries are removed which causes bugs in handling other special cases).
Comment 2 Doug Sherk (:drs) (inactive) 2011-12-01 21:48:45 PST
Try push: https://tbpl.mozilla.org/?tree=Try&rev=abe278c327db
Comment 3 Joe Drew (not getting mail) 2011-12-07 11:06:25 PST
Comment on attachment 578496 [details] [diff] [review]
Patch v1.0, move some special cases to static blocklist.

Review of attachment 578496 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the cleanups

::: widget/src/android/GfxInfo.cpp
@@ +309,5 @@
> +     * It is staying here for reference. The best way to do this now is to add
> +     * an entry in the list above. There is a dummy entry which will whitelist a
> +     * device when uncommented and device/vendor IDs are inserted. It is
> +     * preferred that we stop whitelisting and instead go to blocklisting, where
> +     * everything is assumed to be okay as long as it's not in the blocklist. */

I think we should just delete this code altogether. We can always find it in mercurial. :)

::: widget/src/cocoa/GfxInfo.mm
@@ +400,5 @@
>    {
>      status = nsIGfxInfo::FEATURE_BLOCKED_OS_VERSION;
>    }
>  
> +  // The code around the following has been moved into the global blocklist.

Let's just delete the whole block.
Comment 4 Doug Sherk (:drs) (inactive) 2011-12-07 15:08:28 PST
Created attachment 579857 [details] [diff] [review]
Patch v1.1, move some special cases to the static blocklist.

Removed comments/old code. +r carried
Comment 5 Doug Sherk (:drs) (inactive) 2011-12-14 23:55:28 PST
https://tbpl.mozilla.org/?rev=fe937bac6e75
Comment 6 Doug Sherk (:drs) (inactive) 2011-12-15 01:23:47 PST
https://hg.mozilla.org/mozilla-central/rev/8f7893e1c20c
Comment 7 Benoit Jacob [:bjacob] (mostly away) 2012-03-08 15:13:47 PST
Backed out from beta only:
http://hg.mozilla.org/releases/mozilla-beta/rev/08e1dd305b6b
See bug 711656 for explanation.

Note You need to log in before you can comment on or make changes to this bug.