Closed Bug 705993 Opened 8 years ago Closed 8 years ago

read recommended-addons.json from the profile dir

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: blassey, Assigned: blassey)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
the content of the recommended-addons.json file in my profile is '{"addons":[]}', this shouldn't land until that has content
Attachment #577872 - Flags: review?(mark.finkle)
Depends on: 706393
(In reply to Brad Lassey [:blassey] from comment #1)
> Created attachment 577872 [details] [diff] [review] [diff] [details] [review]
> patch
> 
> the content of the recommended-addons.json file in my profile is
> '{"addons":[]}', this shouldn't land until that has content

This is probably right. AMO has zero support for Fennec Native. There are zero add-ons in AMO for the app.. In fact, the two add-ons you have in the hard coded list will not install in Fennec Native.
Comment on attachment 577872 [details] [diff] [review]
patch

>diff --git a/mobile/android/base/AboutHomeContent.java b/mobile/android/base/AboutHomeContent.java
>@@ -152,17 +152,37 @@ public class AboutHomeContent extends Li
>         });
>     }
> 
>+
>+    InputStream getProfileRecommendedAddonsStream() {

nit: Remove the extra line

>+        }
>+        return null;
>+    }
>+    InputStream getRecommendedAddonsStream(Activity activity) throws Exception{
>+        InputStream is = getProfileRecommendedAddonsStream();

nit: Add a line break between methods
Attachment #577872 - Flags: review?(mark.finkle) → review+
Based on comment 2, you should feel free to land this when the dependent bug is ready.
pushed https://hg.mozilla.org/projects/birch/rev/21ee0cd78262
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.