Closed Bug 705998 Opened 13 years ago Closed 13 years ago

IonMonkey: ion/bug674694.js hangs with greedy allocator

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

Seems to be a regression from my block reordering patch (bug 699415). I'll investigate.
Reduced:

function f0(p0) {
    do {
    } while (p0);

    while (p0) {
        do {
        } while (p0);
    }
}
f0(0);
Attached patch FixSplinter Review
The block ordering change broke FindNaturalLoops, it has to see inner backedges before outer backedges.
Attachment #577523 - Flags: review?(sstangl)
Attachment #577523 - Flags: review?(sstangl) → review+
Thanks for the quick review.

http://hg.mozilla.org/projects/ionmonkey/rev/10b888d2474a
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
The issue is not entirely fixed: the assert introduced by the above patch trips basic/innerLoopIntOuterDouble.js with --ion --ion-regalloc=greedy.

Unfortunately, the assert must know about the osrBlock's ID.
Attachment #577807 - Flags: review?(dvander)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #577807 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/485dcdd9dabd
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.