706010 - Remove NS_SPECIALIZE_TEMPLATE

Status: RESOLVED FIXED

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

We're using 'template<>' and 'template <>' all over the place without ifdefs and nobody complained, afaict. Filing this bug to replace the macro and its remaining users, as well as the HAVE_CPP_MODERN_SPECIALIZE_TEMPLATE_SYNTAX define.

See:

http://mxr.mozilla.org/mozilla-central/ident?i=NS_SPECIALIZE_TEMPLATE
http://mxr.mozilla.org/mozilla-central/search?string=HAVE_CPP_MODERN_SPECIALIZE_TEMPLATE_SYNTAX&find=&findi=&filter=&hitlimit=&tree=mozilla-central

Comment 1

[Andrew Quartey [:drexler]]

Attachment: Patch v1

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 578910 [details] [diff] [review]
Patch v1

>--- a/xpcom/base/nscore.h
>+++ b/xpcom/base/nscore.h
>@@ -389,39 +389,32 @@ typedef PRUint32 nsrefcnt;
>     |template <>| notation.  The compiler that don't understand this notation
>     just omit it for specialization.
> 
>     Need to add an autoconf test for this.
>   */

You'll want to fix that comment as well. Looks good otherwise.

Comment 3

[Andrew Quartey [:drexler]]

Attachment: Patch v2

Comment fixed in xpcom\base\nscore.h

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 578952 [details] [diff] [review]
Patch v2

Thanks!

Comment 5

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 578952 [details] [diff] [review]
Patch v2

Review of attachment 578952 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ -4005,5 @@
>                                 ac_cv_cpp_modern_specialize_template_syntax=yes,
>                                 ac_cv_cpp_modern_specialize_template_syntax=no)])
> -if test "$ac_cv_cpp_modern_specialize_template_syntax" = yes ; then
> -  AC_DEFINE(HAVE_CPP_MODERN_SPECIALIZE_TEMPLATE_SYNTAX)
> -fi

If we're going to require that the compiler support this we want this to be a configure error, no?

Comment 6

[Andrew Quartey [:drexler]]

Attachment: Patch v3

changes to configure.in  in /src and js/src to indicate error if compiler doesn't support template specialization.

Comment 7

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 580142 [details] [diff] [review]
Patch v3

Review of attachment 580142 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing that. r=me on the build bits.

::: configure.in
@@ +4005,5 @@
>                                 ac_cv_cpp_modern_specialize_template_syntax=yes,
>                                 ac_cv_cpp_modern_specialize_template_syntax=no)])
> +if test "$ac_cv_cpp_modern_specialize_template_syntax" = no ; then
> +  AC_MSG_ERROR([The C++ compiler's version: $CXX_VERSION does not support template specialization. See https://developer.mozilla.org/En/Developer_Guide])
> +fi

Just "The C++ compiler does not support template specialization" is sufficient, I think.

Comment 8

[Andrew Quartey [:drexler]]

Attachment: Patch v4

Changed to suggested error message.

Comment 9

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/?tree=Try&rev=73b8ab2861e1

Will push tomorrow presuming green :-)

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d401db5bf913

\o/