Closed Bug 706079 Opened 8 years ago Closed 8 years ago

ignore aria-activedescendant referent having no ARIA role

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 2 open bugs)

Details

(Keywords: access)

Attachments

(1 file)

Attached patch patchSplinter Review
That should be expensive to check aria-activedescendant parent for any element having ID. We ignore aria-activedencendant in some cases for example we do that for focusable state calculation. I think we should take this as a rule to ignore aria-activedescendant referents having no ARIA role. It doesn't make sense to manage HTML controls having no ARIA role by aria-activedescendant because they should be managed by DOM focus. And it doesn't make sense to allow aria-activedensendant pointing to elements having no semantics. So I don't see a usecase for that and thus let's save some time by ignoring such elements.
Attachment #577572 - Attachment is patch: true
Attachment #577572 - Flags: review?(bolterbugz)
I need to better understand the purpose of this change. How did this bug come about? Is "it doesn't make sense to allow aria-activedensendant pointing to elements having no semantics" specifically talking about semantics as in ARIA semantics? html::TD has implicit semantics for example.
(In reply to David Bolter [:davidb] from comment #1)
> I need to better understand the purpose of this change. How did this bug
> come about? 

cleaning up aria-activedescendant implementation

> Is "it doesn't make sense to allow aria-activedensendant
> pointing to elements having no semantics" specifically talking about
> semantics as in ARIA semantics? html::TD has implicit semantics for example.

I didn't think about html:td when I said that, so maybe 'focusable semantics'.
Comment on attachment 577572 [details] [diff] [review]
patch

Review of attachment 577572 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. I hope the role requirement doesn't break anyone.

::: accessible/src/base/nsAccessibilityService.cpp
@@ -926,1 @@
>  }

This removal seems hypothetically dangerous, but I think I'm okay with it.
Attachment #577572 - Flags: review?(bolterbugz) → review+
All's well with the try-build. I think this is safe to land.
landed https://hg.mozilla.org/mozilla-central/rev/0ed3beaf8247
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.