Closed Bug 706149 Opened 8 years ago Closed 8 years ago

Improve Firefox browser_bug462289.js, after SeaMonkey bug 630140

Categories

(Firefox :: Tabbed Browser, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 11

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

Identical to bug 630140 patch Bv3-FF.
Attachment #577659 - Flags: review?(dao)
Attachment #577659 - Flags: review?(dao) → review?(enndeakin)
Comment on attachment 577659 [details] [diff] [review]
(Av1) browser_bug462289.js: Improve checks and documentation

>From: Serge Gautherie <sgautherie.bz@free.fr>
>-  is(document.activeElement, tab1, "tab key to tab activeElement");
>+  is(gBrowser.selectedTab, tab1, "tab key to selected tab1 keeps tab selected");
>+  // Ftr, tab1 is activated and its focus is visible too.
>+  is(document.activeElement, tab1, "tab key to selected tab1 activates tab");
> 

Not sure what 'Ftr' means, but remove it.

>+  // listener, and focuses the current tab if another tab previously had focus.
>+  is(gBrowser.selectedTab, tab2, "click on tab2 while tab1 is activated selects tab");
>+  // XXX  Ftr, this works as expected when running this test,
>+  //      yet, in real life, tab2 is activated but its focus is not visible :-/
>+  //      Maybe related to the additional hover that is not simulated in the test?

This issue looks to be windows specific. Can you instead file a bug on this?
Attachment #577659 - Flags: review?(enndeakin) → review+
Blocks: 707687
(In reply to Neil Deakin from comment #2)

> Not sure what 'Ftr' means, but remove it.

"For the record".

> This issue looks to be windows specific. Can you instead file a bug on this?

I filed bug 707687.
Keywords: checkin-needed
https://tbpl.mozilla.org/?tree=Try&rev=73b8ab2861e1

Will push tomorrow presuming green :-)
https://hg.mozilla.org/mozilla-central/rev/2b60fb6d0e64
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Attachment #579066 - Attachment description: (Av1a) browser_bug462289.js: Improve checks and documentation → (Av1a) browser_bug462289.js: Improve checks and documentation [Checked in: Comment 6]
Attachment #579066 - Flags: checkin+
You need to log in before you can comment on or make changes to this bug.