Last Comment Bug 706149 - Improve Firefox browser_bug462289.js, after SeaMonkey bug 630140
: Improve Firefox browser_bug462289.js, after SeaMonkey bug 630140
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Firefox 11
Assigned To: Serge Gautherie (:sgautherie)
:
: Dão Gottwald [:dao]
Mentors:
http://mxr.mozilla.org/comm-central/f...
Depends on: 630140
Blocks: 707687
  Show dependency treegraph
 
Reported: 2011-11-29 10:11 PST by Serge Gautherie (:sgautherie)
Modified: 2012-02-01 13:59 PST (History)
0 users
emorley: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
(Av1) browser_bug462289.js: Improve checks and documentation (3.99 KB, patch)
2011-11-29 10:21 PST, Serge Gautherie (:sgautherie)
enndeakin: review+
Details | Diff | Splinter Review
(Av1a) browser_bug462289.js: Improve checks and documentation [Checked in: Comment 6] (3.72 KB, patch)
2011-12-05 07:43 PST, Serge Gautherie (:sgautherie)
bugzillamozillaorg_serge_20140323: checkin+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2011-11-29 10:11:20 PST
Per bug 630140 comment 36.
Comment 1 Serge Gautherie (:sgautherie) 2011-11-29 10:21:10 PST
Created attachment 577659 [details] [diff] [review]
(Av1) browser_bug462289.js: Improve checks and documentation

Identical to bug 630140 patch Bv3-FF.
Comment 2 Neil Deakin 2011-12-05 06:54:08 PST
Comment on attachment 577659 [details] [diff] [review]
(Av1) browser_bug462289.js: Improve checks and documentation

>From: Serge Gautherie <sgautherie.bz@free.fr>
>-  is(document.activeElement, tab1, "tab key to tab activeElement");
>+  is(gBrowser.selectedTab, tab1, "tab key to selected tab1 keeps tab selected");
>+  // Ftr, tab1 is activated and its focus is visible too.
>+  is(document.activeElement, tab1, "tab key to selected tab1 activates tab");
> 

Not sure what 'Ftr' means, but remove it.

>+  // listener, and focuses the current tab if another tab previously had focus.
>+  is(gBrowser.selectedTab, tab2, "click on tab2 while tab1 is activated selects tab");
>+  // XXX  Ftr, this works as expected when running this test,
>+  //      yet, in real life, tab2 is activated but its focus is not visible :-/
>+  //      Maybe related to the additional hover that is not simulated in the test?

This issue looks to be windows specific. Can you instead file a bug on this?
Comment 3 Serge Gautherie (:sgautherie) 2011-12-05 07:43:06 PST
Created attachment 579066 [details] [diff] [review]
(Av1a) browser_bug462289.js: Improve checks and documentation
[Checked in: Comment 6]

Av1, with comment 2 suggestion(s).
Comment 4 Serge Gautherie (:sgautherie) 2011-12-05 07:52:39 PST
(In reply to Neil Deakin from comment #2)

> Not sure what 'Ftr' means, but remove it.

"For the record".

> This issue looks to be windows specific. Can you instead file a bug on this?

I filed bug 707687.
Comment 5 Ed Morley [:emorley] 2011-12-12 18:09:00 PST
https://tbpl.mozilla.org/?tree=Try&rev=73b8ab2861e1

Will push tomorrow presuming green :-)
Comment 6 Ed Morley [:emorley] 2011-12-13 06:28:38 PST
https://hg.mozilla.org/mozilla-central/rev/2b60fb6d0e64

Note You need to log in before you can comment on or make changes to this bug.