Attachment #577659 - Flags: review?(dao) → review?(enndeakin)
Comment on attachment 577659 [details] [diff] [review] (Av1) browser_bug462289.js: Improve checks and documentation >From: Serge Gautherie <firstname.lastname@example.org> >- is(document.activeElement, tab1, "tab key to tab activeElement"); >+ is(gBrowser.selectedTab, tab1, "tab key to selected tab1 keeps tab selected"); >+ // Ftr, tab1 is activated and its focus is visible too. >+ is(document.activeElement, tab1, "tab key to selected tab1 activates tab"); > Not sure what 'Ftr' means, but remove it. >+ // listener, and focuses the current tab if another tab previously had focus. >+ is(gBrowser.selectedTab, tab2, "click on tab2 while tab1 is activated selects tab"); >+ // XXX Ftr, this works as expected when running this test, >+ // yet, in real life, tab2 is activated but its focus is not visible :-/ >+ // Maybe related to the additional hover that is not simulated in the test? This issue looks to be windows specific. Can you instead file a bug on this?
Attachment #577659 - Flags: review?(enndeakin) → review+
(In reply to Neil Deakin from comment #2) > Not sure what 'Ftr' means, but remove it. "For the record". > This issue looks to be windows specific. Can you instead file a bug on this? I filed bug 707687.
https://tbpl.mozilla.org/?tree=Try&rev=73b8ab2861e1 Will push tomorrow presuming green :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
You need to log in before you can comment on or make changes to this bug.