Unnecessary glFinish before glReadPixels in LayerManagerOGL

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
In LayerManagerOGL::CopyToTarget(), we use glReadPixels to download the data from the GPU. glReadPixels implies glFinish, which means the preceeding glFinish here is redundant.
(Assignee)

Comment 1

6 years ago
https://tbpl.mozilla.org/?tree=Try&rev=a49982bcecf6
Everytime a useless glFinish call goes away, my personal happiness gets incremented.
(Assignee)

Comment 3

6 years ago
Created attachment 578131 [details] [diff] [review]
Remove unnecessary glFinish before glReadPixels in LayerManagerOGL
Assignee: nobody → jgilbert
Attachment #578131 - Flags: review?(bjacob)
Attachment #578131 - Flags: review?(bjacob) → review+
(Assignee)

Comment 4

6 years ago
Derp, almost forgot the inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/e0dd8b223460
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/e0dd8b223460
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.