Last Comment Bug 706297 - Unnecessary glFinish before glReadPixels in LayerManagerOGL
: Unnecessary glFinish before glReadPixels in LayerManagerOGL
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla11
Assigned To: Jeff Gilbert [:jgilbert]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-29 15:28 PST by Jeff Gilbert [:jgilbert]
Modified: 2011-12-01 04:49 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove unnecessary glFinish before glReadPixels in LayerManagerOGL (1014 bytes, patch)
2011-11-30 16:30 PST, Jeff Gilbert [:jgilbert]
jacob.benoit.1: review+
Details | Diff | Splinter Review

Description Jeff Gilbert [:jgilbert] 2011-11-29 15:28:04 PST
In LayerManagerOGL::CopyToTarget(), we use glReadPixels to download the data from the GPU. glReadPixels implies glFinish, which means the preceeding glFinish here is redundant.
Comment 1 Jeff Gilbert [:jgilbert] 2011-11-29 16:08:54 PST
https://tbpl.mozilla.org/?tree=Try&rev=a49982bcecf6
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2011-11-29 19:06:07 PST
Everytime a useless glFinish call goes away, my personal happiness gets incremented.
Comment 3 Jeff Gilbert [:jgilbert] 2011-11-30 16:30:25 PST
Created attachment 578131 [details] [diff] [review]
Remove unnecessary glFinish before glReadPixels in LayerManagerOGL
Comment 4 Jeff Gilbert [:jgilbert] 2011-12-01 03:55:41 PST
Derp, almost forgot the inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/e0dd8b223460
Comment 5 Marco Bonardo [::mak] (Away 6-20 Aug) 2011-12-01 04:49:37 PST
https://hg.mozilla.org/mozilla-central/rev/e0dd8b223460

Note You need to log in before you can comment on or make changes to this bug.