<maction> doesn't work when click event is called stopPropagation()

RESOLVED FIXED in mozilla11

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

(Blocks 1 bug)

Trunk
mozilla11
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

Load the URI, you cannot toggle the maction's content.
Posted patch PatchSplinter Review
This also fixes another bug the frame doesn't check defaultPrevented value.
Attachment #577930 - Flags: review?(karlt)
Attachment #577930 - Flags: review?(bugs)
Attachment #577930 - Flags: review?(bugs) → review+
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #1)
> Created attachment 577930 [details] [diff] [review] [diff] [details] [review]
> Patch
> 
> This also fixes another bug the frame doesn't check defaultPrevented value.

Does this fix bug 433774?
Attachment #577930 - Flags: review?(karlt) → review+
(In reply to Frédéric Wang from comment #2)
> (In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #1)
> > Created attachment 577930 [details] [diff] [review] [diff] [details] [review] [diff] [details] [review]
> > Patch
> > 
> > This also fixes another bug the frame doesn't check defaultPrevented value.
> 
> Does this fix bug 433774?

On the testcase, no. The click event is fired on <mn> rather than <maction>. So, the testcase doesn't make sense.
But that is a good point, I'll land the patch without defaultPrevented code, and I'll attach a new patch to the bug.
https://hg.mozilla.org/mozilla-central/rev/a8192280c3b3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Blocks: maction
You need to log in before you can comment on or make changes to this bug.