Last Comment Bug 706406 - <maction> doesn't work when click event is called stopPropagation()
: <maction> doesn't work when click event is called stopPropagation()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: MathML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan)
:
: Anthony Jones (:kentuckyfriedtakahe, :k17e)
Mentors:
data:text/html,<math xmlns="http://ww...
Depends on: 703150
Blocks: maction
  Show dependency treegraph
 
Reported: 2011-11-30 01:17 PST by Masayuki Nakano [:masayuki] (Mozilla Japan)
Modified: 2012-01-10 08:44 PST (History)
3 users (show)
masayuki: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (9.84 KB, patch)
2011-11-30 05:11 PST, Masayuki Nakano [:masayuki] (Mozilla Japan)
bugs: review+
karlt: review+
Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-11-30 01:17:22 PST
Load the URI, you cannot toggle the maction's content.
Comment 1 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-11-30 05:11:08 PST
Created attachment 577930 [details] [diff] [review]
Patch

This also fixes another bug the frame doesn't check defaultPrevented value.
Comment 2 Frédéric Wang (:fredw) 2011-11-30 07:46:29 PST
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #1)
> Created attachment 577930 [details] [diff] [review] [diff] [details] [review]
> Patch
> 
> This also fixes another bug the frame doesn't check defaultPrevented value.

Does this fix bug 433774?
Comment 3 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-11-30 17:45:25 PST
(In reply to Frédéric Wang from comment #2)
> (In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #1)
> > Created attachment 577930 [details] [diff] [review] [diff] [details] [review] [diff] [details] [review]
> > Patch
> > 
> > This also fixes another bug the frame doesn't check defaultPrevented value.
> 
> Does this fix bug 433774?

On the testcase, no. The click event is fired on <mn> rather than <maction>. So, the testcase doesn't make sense.
Comment 4 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-11-30 17:49:24 PST
But that is a good point, I'll land the patch without defaultPrevented code, and I'll attach a new patch to the bug.
Comment 5 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-11-30 23:52:20 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8192280c3b3
Comment 6 Matt Brubeck (:mbrubeck) 2011-12-01 11:23:18 PST
https://hg.mozilla.org/mozilla-central/rev/a8192280c3b3

Note You need to log in before you can comment on or make changes to this bug.