706427 - Computed View search should work with all color types

Status: RESOLVED WONTFIX

(DevTools :: Inspector, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Simple html file including the color convertion methods

The style inspector search is a simple string search but it would be far better if it could return color values that match even when the color types do not:

e.g. Searching for "red" should also return the following:
red
#FF0000
#F00
rgb(255, 0, 0)
hsl(0, 100%, 50%)
hsla(0, 100%, 50%, 1)
rgb(255, 0, 0)
rgba(255, 0, 0, 1)

Comment 1

[Rob Campbell [:rc] (:robcee)]

note that the attached proof of concept, while neat, doesn't necessarily demonstrate what searching for a color will look like. Maybe enumerating all of the possible values for blue would be more indicative of what's happening.

Comment 2

[Rob Campbell [:rc] (:robcee)]

I'm also more curious about the algorithm behind the search. Do we precalculate possible matches for colors? Generate some kind of key up front? A table of conversions? This could be quite tricky to do well.

Comment 3

[Dave Camp (:dcamp)]

Presumably we can just normalize to a particular color representation

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I would use a hasColor method that checks against each color type in turn and returns true on a match. As long as the colors are cached as we calculate them we have good performance and low memory useage.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Bug triage, filter on PEGASUS.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We decided against doing this as search results would be confusing e.g. When searching for 100% we don't want red to appear in the list of results.