706443 - The New Bug form ignores the defaultplatform and defaultopsys parameters

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Christian Holler (:decoder)]

When I create a bug template with an explicit architecture set that differs from the architecture of the machine I'm currently using, then the architecture is set to that of my machine as soon as I use the bookmarked template.

Steps to reproduce:

1. Create a bug template with an architecture that is not that of your own machine (e.g. select x86-64 if your machine is x86).
2. Save as bookmark, then visit page.
3. Observe that architecture is set back to that of your own machine (e.g. x86) instead of what the template said.


Tested with the bugzilla installation at bugzilla.mozilla.org.

Comment 1

[Frédéric Buclin]

This happens with the 4.3 code only. Bugzilla 4.2 and older are not affected. The fact that bmo is affected means that it backported the culprit code from upstream.

Comment 2

[Frédéric Buclin]

Oh, and I updated the bug summary to reflect the fact that you don't need to bookmark the page to reproduce the issue. The defaultplatform and defaultopsys parameters are ignored, and so are the values stored in the bookmark as well.

Comment 3

[Frédéric Buclin]

This is a regression due to bug 307688. It totally ignores 1) the field values pass to the URL, if any, and 2) the default values set in the parameters.

Comment 4

[David Lawrence [:dkl]]

Attachment: Patch to allow setting of op_sys/platform from bookmarked template (v1)

Patch to fix this problem.

dkl

Comment 5

[Frédéric Buclin]

Comment on attachment 577969 [details] [diff] [review]
Patch to allow setting of op_sys/platform from bookmarked template (v1)

This only fixes the "my values passed in the URL are ignored" part of the problem. If they are not defined, then it must first look at the parameters. The detection code must only be called if the parameters are left empty.

Comment 6

[David Lawrence [:dkl]]

Attachment: Patch to allow setting of op_sys/platform from bookmarked template (v2)

Sorry bout that. Here is a new patch that takes the default param values into account as well.

dkl

Comment 7

[Frédéric Buclin]

Comment on attachment 577999 [details] [diff] [review]
Patch to allow setting of op_sys/platform from bookmarked template (v2)

Great, thanks! r=LpSolit

Comment 8

[David Lawrence [:dkl]]

trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified enter_bug.cgi
Committed revision 8024.

bmo/4.0:
Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified enter_bug.cgi
Committed revision 7970.

bmo/4.2:
Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified enter_bug.cgi
Committed revision 7969.