706479 - Lazyloading of images breaks anchor links

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Verdi [:verdi] Best to slack me]

It looks like anchor links to sections with showfor and images are not working correctly. The url is right but possibly showfor and image loading are causing the wrong section to be at the top of the window.

Example:
https://support.mozilla.com/en-US/kb/how-do-i-manage-my-firefox-sync-account#w_where-can-i-find-my-recovery-key

Comment 1

[Verdi [:verdi] Best to slack me]

This is still broken.
STR:
1. Go to https://support.mozilla.org/en-US/kb/Options window - Advanced panel
2. Once the page is loaded, reload with shift-reload to make sure you don't have any of the images further down the page loaded.
3. Click on the link to the Encryption tab in the TOC.

Expected result: Encryption tab heading is at the top of the viewport. Actual result: Offline Web Content and User Data heading was the closest to the top of the viewport in my case, your mileage may vary.

Comment 2

[Tanay Gavankar [:tgavankar]]

The old bug that was fixed for anchor links I think fixed for anchors going to other pages - this may only relate to anchors on the same page (although I'm pretty sure that this should also have been fixed...).

Verdi: The STR page you gave is a 404 now, do you have another one that you can repro it on?

Comment 3

[Verdi [:verdi] Best to slack me]

(In reply to Tanay Gavankar [:tgavankar] from comment #2)

> Verdi: The STR page you gave is a 404 now, do you have another one that you
> can repro it on?

Sorry it was just bad link formatting. The page is here: https://support.mozilla.org/en-US/kb/Options%20window%20-%20Advanced%20panel

Comment 4

[Tanay Gavankar [:tgavankar]]

Done in https://github.com/mozilla/kitsune/commit/42a43d1e216f2a5bbc09e7d7e28be125b3142704