The default bug view has changed. See this FAQ.

Add nsRefPtrHashKey

RESOLVED FIXED in mozilla12

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I wound up needing this for my gamepad patches, since I'm hanging on to nsGlobalWindow* directly instead of using interfaces.
(Assignee)

Updated

5 years ago
Blocks: 604039
(Assignee)

Comment 1

5 years ago
Created attachment 578014 [details] [diff] [review]
Add nsRefPtrHashKey

We don't seem to have comprehensive tests on the hashtable stuff, but I'd be happy to add tests for this to TestHashtables.cpp if you'd like.
Attachment #578014 - Flags: review?(benjamin)
Comment on attachment 578014 [details] [diff] [review]
Add nsRefPtrHashKey

Could we just typedef nsRefPtrHashKey<nsISupports> nsISupportsHashKey? Probably doesn't matter though.
Attachment #578014 - Flags: review?(benjamin) → review+
We'd lose comptr logging on hash keys then.  Whether or not people actually care about that, idk.
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/043724be2771
https://hg.mozilla.org/mozilla-central/rev/043724be2771
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.