Closed Bug 706554 Opened 10 years ago Closed 10 years ago

Add nsRefPtrHashKey

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

I wound up needing this for my gamepad patches, since I'm hanging on to nsGlobalWindow* directly instead of using interfaces.
Blocks: 604039
We don't seem to have comprehensive tests on the hashtable stuff, but I'd be happy to add tests for this to TestHashtables.cpp if you'd like.
Attachment #578014 - Flags: review?(benjamin)
Comment on attachment 578014 [details] [diff] [review]
Add nsRefPtrHashKey

Could we just typedef nsRefPtrHashKey<nsISupports> nsISupportsHashKey? Probably doesn't matter though.
Attachment #578014 - Flags: review?(benjamin) → review+
We'd lose comptr logging on hash keys then.  Whether or not people actually care about that, idk.
https://hg.mozilla.org/mozilla-central/rev/043724be2771
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.