The default bug view has changed. See this FAQ.

Remove SetEventCallback

RESOLVED FIXED in mozilla11

Status

()

Core
Widget
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 578012 [details] [diff] [review]
Remove SetEventCallback

It doesn't look like anyone uses SetEventCallback
Attachment #578012 - Flags: review?(roc)
(Assignee)

Comment 2

5 years ago
Created attachment 578016 [details] [diff] [review]
Require the event callback to be defined

mEventCallback appears to always be set, so let's require it and simplify the code that calls it.
Attachment #578016 - Flags: review?(roc)
Comment on attachment 578012 [details] [diff] [review]
Remove SetEventCallback

Review of attachment 578012 [details] [diff] [review]:
-----------------------------------------------------------------

rev nsIWidget IID
Attachment #578012 - Flags: review?(roc) → review+
Attachment #578016 - Flags: review?(roc) → review+
(Assignee)

Comment 4

5 years ago
2nd patch doesn't pass try.. apparently windows cares about windows without an event callback.
(Assignee)

Comment 5

5 years ago
Since we really want to remove code right now, I landed the first patch with a nsIWidget IID rev.

https://hg.mozilla.org/mozilla-central/rev/0723ae8c9416

I'll deal with the 2nd part in another bug once I get to it.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Summary: Simplify Event Callback handling → Remove SetEventCallback
Target Milestone: --- → mozilla11

Comment 6

5 years ago
This was added as part 1 of bug 90268, I'm going to have to add it back again shortly.
You need to log in before you can comment on or make changes to this bug.