Closed
Bug 706558
Opened 13 years ago
Closed 13 years ago
Remove SetEventCallback
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(2 files)
|
2.15 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
8.79 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
It doesn't look like anyone uses SetEventCallback
Attachment #578012 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•13 years ago
|
||
mEventCallback appears to always be set, so let's require it and simplify the code that calls it.
Attachment #578016 -
Flags: review?(roc)
Comment on attachment 578012 [details] [diff] [review]
Remove SetEventCallback
Review of attachment 578012 [details] [diff] [review]:
-----------------------------------------------------------------
rev nsIWidget IID
Attachment #578012 -
Flags: review?(roc) → review+
Attachment #578016 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
2nd patch doesn't pass try.. apparently windows cares about windows without an event callback.
|
|
Assignee | |
Comment 5•13 years ago
|
||
Since we really want to remove code right now, I landed the first patch with a nsIWidget IID rev.
https://hg.mozilla.org/mozilla-central/rev/0723ae8c9416
I'll deal with the 2nd part in another bug once I get to it.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Summary: Simplify Event Callback handling → Remove SetEventCallback
Target Milestone: --- → mozilla11
This was added as part 1 of bug 90268, I'm going to have to add it back again shortly.
You need to log in
before you can comment on or make changes to this bug.
Description
•